Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: Source/devtools/front_end/sdk/OverridesSupport.js

Issue 318653003: [DevTools] Fix integer/double values in emulation input fields. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/elements/OverridesView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/OverridesSupport.js
diff --git a/Source/devtools/front_end/sdk/OverridesSupport.js b/Source/devtools/front_end/sdk/OverridesSupport.js
index 597d521fa246c96404d376562fe6e4a3d36f879a..65f653914d280f9868a56862d7cc523161ad861b 100644
--- a/Source/devtools/front_end/sdk/OverridesSupport.js
+++ b/Source/devtools/front_end/sdk/OverridesSupport.js
@@ -260,13 +260,23 @@ WebInspector.OverridesSupport.DeviceOrientation.clearDeviceOrientationOverride =
/**
* @param {string} value
*/
-WebInspector.OverridesSupport.inputValidator = function(value)
+WebInspector.OverridesSupport.integerInputValidator = function(value)
{
- if (value >= 0 && value <= 10000)
+ if (/^[\d]+$/.test(value) && value >= 0 && value <= 10000)
return "";
return WebInspector.UIString("Value must be non-negative integer");
}
+/**
+ * @param {string} value
+ */
+WebInspector.OverridesSupport.doubleInputValidator = function(value)
+{
+ if (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= 0 && value <= 10000)
+ return "";
+ return WebInspector.UIString("Value must be non-negative float");
+}
+
// Third element lists device metrics separated by 'x':
// - screen width,
// - screen height,
« no previous file with comments | « Source/devtools/front_end/elements/OverridesView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698