Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 318653003: [DevTools] Fix integer/double values in emulation input fields. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/OverridesView.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @implements {WebInspector.OverridesSupport.PageResizer} 8 * @implements {WebInspector.OverridesSupport.PageResizer}
9 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder 9 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder
10 */ 10 */
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 } 431 }
432 432
433 // Screen 433 // Screen
434 sectionElement = this._toolbarElement.createChild("div", "responsive-des ign-section"); 434 sectionElement = this._toolbarElement.createChild("div", "responsive-des ign-section");
435 sectionElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox ("Screen", WebInspector.overridesSupport.settings.overrideDeviceResolution, true )); 435 sectionElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox ("Screen", WebInspector.overridesSupport.settings.overrideDeviceResolution, true ));
436 436
437 var fieldsetElement = WebInspector.SettingsUI.createSettingFieldset(WebI nspector.overridesSupport.settings.overrideDeviceResolution); 437 var fieldsetElement = WebInspector.SettingsUI.createSettingFieldset(WebI nspector.overridesSupport.settings.overrideDeviceResolution);
438 sectionElement.appendChild(fieldsetElement); 438 sectionElement.appendChild(fieldsetElement);
439 fieldsetElement.createChild("div", "responsive-design-icon responsive-de sign-icon-resolution").title = WebInspector.UIString("Screen resolution"); 439 fieldsetElement.createChild("div", "responsive-design-icon responsive-de sign-icon-resolution").title = WebInspector.UIString("Screen resolution");
440 440
441 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "3em", WebI nspector.OverridesSupport.inputValidator, true)); 441 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "3em", WebI nspector.OverridesSupport.integerInputValidator, true));
442 fieldsetElement.appendChild(document.createTextNode(" \u00D7 ")); 442 fieldsetElement.appendChild(document.createTextNode(" \u00D7 "));
443 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em", Web Inspector.OverridesSupport.inputValidator, true)); 443 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em", Web Inspector.OverridesSupport.integerInputValidator, true));
444 444
445 this._swapDimensionsElement = fieldsetElement.createChild("button", "res ponsive-design-icon responsive-design-icon-swap"); 445 this._swapDimensionsElement = fieldsetElement.createChild("button", "res ponsive-design-icon responsive-design-icon-swap");
446 this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensio ns"); 446 this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensio ns");
447 this._swapDimensionsElement.addEventListener("click", WebInspector.overr idesSupport.swapDimensions.bind(WebInspector.overridesSupport), false); 447 this._swapDimensionsElement.addEventListener("click", WebInspector.overr idesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);
448 448
449 fieldsetElement.createChild("div", "responsive-design-icon responsive-de sign-icon-dpr").title = WebInspector.UIString("Device pixel ratio"); 449 fieldsetElement.createChild("div", "responsive-design-icon responsive-de sign-icon-dpr").title = WebInspector.UIString("Device pixel ratio");
450 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 2, "2em" , WebInspector.OverridesSupport.inputValidator, true)); 450 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 4, "2.5e m", WebInspector.OverridesSupport.doubleInputValidator, true));
451 451
452 // Touch and viewport 452 // Touch and viewport
453 sectionElement = this._toolbarElement.createChild("div", "responsive-des ign-section"); 453 sectionElement = this._toolbarElement.createChild("div", "responsive-des ign-section");
454 sectionElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox (WebInspector.UIString("Touch"), WebInspector.overridesSupport.settings.emulateT ouchEvents, true)); 454 sectionElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox (WebInspector.UIString("Touch"), WebInspector.overridesSupport.settings.emulateT ouchEvents, true));
455 sectionElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox (WebInspector.UIString("Viewport"), WebInspector.overridesSupport.settings.emula teViewport, true)); 455 sectionElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox (WebInspector.UIString("Viewport"), WebInspector.overridesSupport.settings.emula teViewport, true));
456 }, 456 },
457 457
458 _overridesWarningUpdated: function() 458 _overridesWarningUpdated: function()
459 { 459 {
460 var message = WebInspector.overridesSupport.warningMessage(); 460 var message = WebInspector.overridesSupport.warningMessage();
461 if (this._warningMessage.textContent === message) 461 if (this._warningMessage.textContent === message)
462 return; 462 return;
463 this._warningMessage.classList.toggle("hidden", !message); 463 this._warningMessage.classList.toggle("hidden", !message);
464 this._warningMessage.textContent = message; 464 this._warningMessage.textContent = message;
465 this._responsiveDesignModeChanged(); 465 this._responsiveDesignModeChanged();
466 this.onResize(); 466 this.onResize();
467 }, 467 },
468 468
469 __proto__: WebInspector.VBox.prototype 469 __proto__: WebInspector.VBox.prototype
470 }; 470 };
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/OverridesView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698