Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318653003: [DevTools] Fix integer/double values in emulation input fields. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[DevTools] Fix integer/double values in emulation input fields. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175484

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-04 11:36:33 UTC) #1
apavlov
lgtm with comments https://codereview.chromium.org/318653003/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/318653003/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode275 Source/devtools/front_end/sdk/OverridesSupport.js:275: if (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= 0 ...
6 years, 6 months ago (2014-06-04 11:42:07 UTC) #2
dgozman
Thank you for review. https://codereview.chromium.org/318653003/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/318653003/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode275 Source/devtools/front_end/sdk/OverridesSupport.js:275: if (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= ...
6 years, 6 months ago (2014-06-04 12:43:20 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-04 12:44:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/318653003/20001
6 years, 6 months ago (2014-06-04 12:44:43 UTC) #5
apavlov
https://codereview.chromium.org/318653003/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/318653003/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode275 Source/devtools/front_end/sdk/OverridesSupport.js:275: if (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= 0 && value <= ...
6 years, 6 months ago (2014-06-04 12:53:56 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 14:15:46 UTC) #7
Message was sent while issue was closed. 
Change committed as 175484

Powered by Google App Engine
This is Rietveld 408576698