Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: content/renderer/dom_serializer_browsertest.cc

Issue 318633003: Disable DomSerializerTests.SerializeHTMLDOMWithEmptyHead under ThreadSanitizer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/dom_serializer_browsertest.cc
diff --git a/content/renderer/dom_serializer_browsertest.cc b/content/renderer/dom_serializer_browsertest.cc
index 5f5ebfed5da566c6d9bc4019ce55fb3d6b26394d..4c513d0a24bceb8c9b55e6620fb1dae01ba7a3ca 100644
--- a/content/renderer/dom_serializer_browsertest.cc
+++ b/content/renderer/dom_serializer_browsertest.cc
@@ -979,8 +979,16 @@ IN_PROC_BROWSER_TEST_F(DomSerializerTests,
base::Unretained(this), file_url, path_dir_url));
}
+#if defined(THREAD_SANITIZER)
+// TSan reports a use-after-free in this test, see http://crbug.com/375672.
+#define MAYBE_SerializeHTMLDOMWithEmptyHead \
+ DISABLED_SerializeHTMLDOMWithEmptyHead
+#else
+#define MAYBE_SerializeHTMLDOMWithEmptyHead SerializeHTMLDOMWithEmptyHead
+#endif
// Serializing page which has an empty HEAD tag.
-IN_PROC_BROWSER_TEST_F(DomSerializerTests, SerializeHTMLDOMWithEmptyHead) {
+IN_PROC_BROWSER_TEST_F(DomSerializerTests,
+ MAYBE_SerializeHTMLDOMWithEmptyHead) {
// Need to spin up the renderer and also navigate to a file url so that the
// renderer code doesn't attempt a fork when it sees a load to file scheme
// from non-file scheme.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698