Allow empty header value in the blink HTTP header parser.

Source/platform/network/HTTPParsersTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "HTTPParsers.h"
 
 #include "wtf/MathExtras.h"
+#include "wtf/testing/WTFTestHelpers.h"
 #include "wtf/text/AtomicString.h"
 
 #include <gtest/gtest.h>
 
 namespace WebCore {
 
+namespace {
+
+size_t parseHTTPHeader(const char* data, String& failureReason, AtomicString& nameStr, AtomicString& valueStr)
+{
+    return WebCore::parseHTTPHeader(data, strlen(data), failureReason, nameStr, valueStr);
+}
+
+} // namespace
+
 TEST(HTTPParsersTest, ParseCacheControl)
 {
     CacheControlHeader header;
 
     header = parseCacheControlDirectives("no-cache", AtomicString());
     EXPECT_TRUE(header.parsed);
     EXPECT_TRUE(header.containsNoCache);
     EXPECT_FALSE(header.containsNoStore);
     EXPECT_FALSE(header.containsMustRevalidate);
     EXPECT_TRUE(std::isnan(header.maxAge));
@@ skipping 62 matching lines @@
     EXPECT_TRUE(std::isnan(header.maxAge));
 
     header = parseCacheControlDirectives(AtomicString(), "no-cache");
     EXPECT_TRUE(header.parsed);
     EXPECT_TRUE(header.containsNoCache);
     EXPECT_FALSE(header.containsNoStore);
     EXPECT_FALSE(header.containsMustRevalidate);
     EXPECT_TRUE(std::isnan(header.maxAge));
 }
 
+TEST(HTTPParsersTest, parseHTTPHeaderSimple)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(11u, parseHTTPHeader("foo:   bar\r\notherdata", failureReason, name, value));
+    EXPECT_TRUE(failureReason.isEmpty());
+    EXPECT_EQ("foo", name.string());
+    EXPECT_EQ("bar", value.string());
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderEmptyName)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader(": bar\r\notherdata", failureReason, name, value));
+    EXPECT_EQ("Invalid UTF-8 sequence in header name", failureReason);
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderEmptyValue)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(6u, parseHTTPHeader("foo: \r\notherdata", failureReason, name, value));
+    EXPECT_TRUE(failureReason.isEmpty());
+    EXPECT_EQ("foo", name.string());
+    EXPECT_TRUE(value.isEmpty());
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderEmpty)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader("", failureReason, name, value));
+    EXPECT_EQ("Unterminated header name", failureReason);
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderEmptyLine)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(2u, parseHTTPHeader("\r\notherdata", failureReason, name, value));
+    EXPECT_TRUE(failureReason.isEmpty());
+    EXPECT_TRUE(name.isNull());
+    EXPECT_TRUE(value.isNull());
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderUnexpectedCRinName)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader("foo\rotherdata\n", failureReason, name, value));
+    EXPECT_EQ("Unexpected CR in name at foo", failureReason);
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderUnexpectedLFinName)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader("foo\notherdata\n", failureReason, name, value));
+    EXPECT_EQ("Unexpected LF in name at foo", failureReason);
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderUnexpectedLFinValue)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader("foo: bar\notherdata\n", failureReason, name, value));
+    EXPECT_EQ("Unexpected LF in value at bar", failureReason);
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderNoLFAtEndOfLine)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader("foo: bar\r", failureReason, name, value));
+    EXPECT_EQ("CR doesn't follow LF after value at ", failureReason);
+}
+
+TEST(HTTPParsersTest, parseHTTPHeaderNoLF)
+{
+    String failureReason;
+    AtomicString name, value;
+    EXPECT_EQ(0u, parseHTTPHeader("foo: bar\rhoge\r\n", failureReason, name, value));
+    EXPECT_EQ("CR doesn't follow LF after value at hoge\r\n", failureReason);
+}
+

[tyoshino (SeeGerritForStatus), 2014/06/04 08:24:12]

add a test that takes input of two lines and check the return value.

[yhirano, 2014/06/04 09:14:03]

Done.

 } // namespace WebCore