Chromium Code Reviews
Help | Chromium Project | Sign in
(457)

Issue 3186021: DONOTLAND: Start of PK11 password dialog for Linux/NSS (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by David Benjamin
Modified:
7 months, 2 weeks ago
Reviewers:
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

DONOTLAND: Start of PK11 password dialog for Linux/NSS

A number of things make this rather messy:

- NSS's dialog is blocking
- WebKit doesn't tell us which tab requested a keygen

So, in the worst case, we need something which blocks on the UI thread with a
dialog. This must be moved to a worker thread. For other things, we can drive
the authentication ourselves with PK11_CheckUserPassword with an asynchronously
dialog.

Another issue is that the hang monitor needs to be stopped as WebKit currently blocks on the key generation. This is a nuisance because WebKit doesn't even tell us what page (WebView?) made the request, so we don't get a render view id and routed IPC. I don't think this can be solved without WebKit-side changes.

Patch Set 1 #

Patch Set 2 : Rebase a bit, add a start for an actual dialog #

Patch Set 3 : Start of hooking up the hang monitor, probably requires WebKit changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -38 lines) Lint Patch
M base/nss_util.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments ? errors Download
M base/nss_util_internal.h View 1 chunk +18 lines, -0 lines 0 comments 0 errors Download
M chrome/app/generated_resources.grd View 2 1 chunk +20 lines, -0 lines 0 comments ? errors Download
A chrome/browser/gtk/pk11_password_dialog.h View 1 chunk +47 lines, -0 lines 0 comments 1 errors Download
A chrome/browser/gtk/pk11_password_dialog.cc View 1 1 chunk +231 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 4 chunks +23 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments ? errors Download
M net/base/keygen_handler.h View 3 chunks +22 lines, -12 lines 0 comments 0 errors Download
A net/base/keygen_handler.cc View 1 chunk +28 lines, -0 lines 0 comments 1 errors Download
M net/base/keygen_handler_nss.cc View 2 chunks +26 lines, -1 line 0 comments 0 errors Download
M net/net.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments ? errors Download
M net/third_party/mozilla_security_manager/nsKeygenHandler.h View 2 chunks +3 lines, -0 lines 0 comments 0 errors Download
M net/third_party/mozilla_security_manager/nsKeygenHandler.cpp View 5 chunks +1 line, -25 lines 0 comments 0 errors Download
Trybot results:
Commit:

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6