Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2698)

Unified Diff: chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc

Issue 318563002: [fsp] Introduce BufferingFileStreamReader to read files in bigger chunks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc
diff --git a/chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc b/chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc
index c63e8a2583e8c8e268343ce2972fa5813e34a035..069126bca796e3c58cb22c379106730d04108124 100644
--- a/chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc
+++ b/chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.h"
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.h"
#include "chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.h"
#include "chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.h"
#include "content/public/browser/browser_thread.h"
@@ -16,6 +17,13 @@ using content::BrowserThread;
namespace chromeos {
namespace file_system_provider {
+namespace {
+
+// Size of the stream reader internal buffer. At most this number of bytes will
+// be read ahead of the requested data.
+const int kReaderBufferSize = 512 * 1024; // 512KB.
+
+} // namespace
BackendDelegate::BackendDelegate()
: async_file_util_(new internal::ProviderAsyncFileUtil) {}
@@ -39,7 +47,10 @@ BackendDelegate::CreateFileStreamReader(
DCHECK_EQ(fileapi::kFileSystemTypeProvided, url.type());
return scoped_ptr<webkit_blob::FileStreamReader>(
- new FileStreamReader(context, url, offset, expected_modification_time));
+ new BufferingFileStreamReader(
+ scoped_ptr<webkit_blob::FileStreamReader>(new FileStreamReader(
+ context, url, offset, expected_modification_time)),
+ kReaderBufferSize));
}
scoped_ptr<fileapi::FileStreamWriter> BackendDelegate::CreateFileStreamWriter(
« no previous file with comments | « no previous file | chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698