Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Issue 31853003: Remove GrContext from SkXfermode::[Aa]sNewEffectOrCoeff() and all subclasses, (Closed)

Created:
7 years, 2 months ago by Stephen White
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove GrContext from SkXfermode::[Aa]sNewEffectOrCoeff() and all subclasses, since it's unused. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M include/core/SkMaskFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkXfermode.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
Brian, PTAL. Thanks!
7 years, 2 months ago (2013-10-23 14:01:52 UTC) #1
bsalomon
lgtm
7 years, 2 months ago (2013-10-23 14:02:30 UTC) #2
Stephen White
7 years, 2 months ago (2013-10-23 14:03:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11913 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698