Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 318523002: Unflake fast/loader/resources/unload-hyperlink-targeted-subframe.html (Closed)

Created:
6 years, 6 months ago by eseidel
Modified:
6 years, 6 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, abarth-chromium
Visibility:
Public.

Description

Unflake fast/loader/resources/unload-hyperlink-targeted-subframe.html Prior to this change --iterations=10 would fail about 50% of the runs of this test. After this change I see 0 failures. Unclear if this test still tests exactly what it set out to but it seems like it should. R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M LayoutTests/fast/loader/resources/unload-hyperlink-targeted-subframe.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nate Chapin
lgtm
6 years, 6 months ago (2014-06-03 21:52:57 UTC) #1
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 6 months ago (2014-06-03 21:53:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/318523002/1
6 years, 6 months ago (2014-06-03 21:54:17 UTC) #3
eseidel
Was the original author of this change. https://bugs.webkit.org/show_bug.cgi?id=29747 IT's been very flaky for a long ...
6 years, 6 months ago (2014-06-03 21:56:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-03 23:54:53 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 00:58:28 UTC) #6
Message was sent while issue was closed.
Change committed as 175416

Powered by Google App Engine
This is Rietveld 408576698