Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 318503002: GN: Make wtf_unittests build on mac/clang (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw, eseidel
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium
Visibility:
Public.

Description

GN: Make wtf_unittests build on mac/clang On clang we enable -Wglobal-constructors which bans static initializers. This is correct for all targets except unit test binaries, which need static initializers since that's how the gtest TEST{,_F,_P} family of macros work. This splits that warning into a separate config and avoids adding it to the unit test targets. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175424

Patch Set 1 #

Total comments: 2

Patch Set 2 : reformat comment #

Patch Set 3 : depend on //base/allocator unconditionally, rely on allocator type switch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M Source/BUILD.gn View 1 3 chunks +12 lines, -1 line 0 comments Download
M Source/platform/BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/wtf/BUILD.gn View 1 2 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
brettw@ for review eseidel@ for OWNERS on Source/BUILD.gn With this wtf_unittests builds and runs on ...
6 years, 6 months ago (2014-06-03 20:58:26 UTC) #1
brettw
https://codereview.chromium.org/318503002/diff/1/Source/BUILD.gn File Source/BUILD.gn (right): https://codereview.chromium.org/318503002/diff/1/Source/BUILD.gn#newcode72 Source/BUILD.gn:72: # The follow configs apply to all targets except ...
6 years, 6 months ago (2014-06-03 21:14:03 UTC) #2
eseidel
rslgtm
6 years, 6 months ago (2014-06-03 21:17:44 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-03 21:34:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/318503002/20001
6 years, 6 months ago (2014-06-03 21:35:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 23:39:36 UTC) #6
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-03 23:49:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/318503002/40001
6 years, 6 months ago (2014-06-03 23:49:36 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 02:01:39 UTC) #9
Message was sent while issue was closed.
Change committed as 175424

Powered by Google App Engine
This is Rietveld 408576698