Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 318493002: Android: remove -lcutils dependency (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
scroggo, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Android: remove -lcutils dependency I believe we no longer depend on this after we ported our atomics to __sync. Tested by running android_ninja. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bec3634a4a0bc2ca872f8b6b7a9f445929e9f74b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M gyp/bench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/dm.gyp View 1 1 chunk +1 line, -4 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/bin/android_gdbserver View 2 chunks +1 line, -2 lines 0 comments Download
M platform_tools/android/bin/android_perf View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 6 months ago (2014-06-03 20:31:37 UTC) #1
scroggo
lgtm
6 years, 6 months ago (2014-06-03 20:46:58 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-03 20:47:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/318493002/1
6 years, 6 months ago (2014-06-03 20:47:39 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-03 21:00:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/318493002/20001
6 years, 6 months ago (2014-06-03 21:00:55 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 22:38:22 UTC) #7
Message was sent while issue was closed.
Change committed as bec3634a4a0bc2ca872f8b6b7a9f445929e9f74b

Powered by Google App Engine
This is Rietveld 408576698