Issue 318463002: Revert of Pepper: Refactor OpenManifestEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318463002: Revert of Pepper: Refactor OpenManifestEntry. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Pepper: Refactor OpenManifestEntry. (https://codereview.chromium.org/302093012/) Reason for revert: This broke NaClBrowserTestPnaclNonSfi.IrtManifestFile on linux 32. That test will have to pass on the right trybot before landing. I'm not sure why it broke yet. Original issue's description: > Pepper: Refactor OpenManifestEntry. > > This change pulls out more OpenManifestEntry code from service_runtime, making > PPB_NaCl_Private a smallter interface, and preparing for pulling all of that > logic out of the trusted plugin. > > BUG=239656 > R=dmichael@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274530 TBR=dmichael@chromium.org NOTREECHECKS=true NOTRY=true BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274588

Patch Set 1 #

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -82 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	6 chunks	+29 lines, -50 lines	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	2 chunks	+13 lines, -11 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	3 chunks	+12 lines, -11 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View	2 chunks	+50 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	3 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/318463002/1

6 years, 6 months ago (2014-06-03 19:10:03 UTC) #2

Message was sent while issue was closed.

Change committed as 274588

Expand Messages | Collapse Messages