Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1378)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html
Issue
318443004
:
Fix off by one in creating a RasterShape (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update for review feedback
Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt
Source/core/rendering/shapes/RasterShape.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« no previous file
|
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
div {
4
width: 5px;
5
height: 5px;
6
margin-top: 2px;
7
shape-margin: 2px;
8
shape-outside: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/20 00/svg' width='5' height='5'><rect x='0' y='0' width='100%' height='100%'/></svg >");
9
float:left;
10
}
11
</style>
12
<script>
13
if (window.testRunner)
14
testRunner.dumpAsText();
15
</script>
16
<body>
17
<div></div>
18
This test should not crash in a debug build.
19
</body>
OLD
NEW
« no previous file with comments
|
« no previous file
|
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt »
('j') |
no next file with comments »
Issue 318443004: Fix off by one in creating a RasterShape (Closed)
Created 6 years, 6 months ago by Bem Jones-Bey (adobe)
Modified 6 years, 6 months ago
Reviewers: Bear Travis, inferno, pdr.
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 1
This is Rietveld
408576698
Chromium Code Reviews
Issue 318443004:
Fix off by one in creating a RasterShape (Closed)
Base URL: svn://svn.chromium.org/blink/trunk