Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 318433003: Added grid data to logging output (Closed)

Created:
6 years, 6 months ago by kelvinly
Modified:
6 years, 6 months ago
Reviewers:
jcgregorio, benchen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Added grid data to logging output BUG=skia: Committed: https://skia.googlesource.com/skia/+/06fdc6937df52942226a0a5e7bba169c27006ef1

Patch Set 1 #

Patch Set 2 : Managed to make a typo in 5 lines of code #

Patch Set 3 : Two typos #

Patch Set 4 : Changed underscore to x to improve parsing #

Total comments: 2

Patch Set 5 : Changed from using public members to getters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/PictureRenderer.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kelvinly
Added the grid width and height to the logging output. It builds, but I haven't ...
6 years, 6 months ago (2014-06-03 18:27:23 UTC) #1
benchen
https://codereview.chromium.org/318433003/diff/60001/tools/PictureRenderer.h File tools/PictureRenderer.h (right): https://codereview.chromium.org/318433003/diff/60001/tools/PictureRenderer.h#newcode264 tools/PictureRenderer.h:264: config.appendS32(fGridInfo.fTileInterval.fWidth); I didn't see fWidth used with fTileInterval. https://github.com/google/skia/blob/770963f23f4fc313db0fa3bac18b1b8aafb55f17/src/core/SkBBHFactory.cpp#L40 ...
6 years, 6 months ago (2014-06-03 18:46:33 UTC) #2
kelvinly
Changed from fWidth/Height to width/height() https://codereview.chromium.org/318433003/diff/60001/tools/PictureRenderer.h File tools/PictureRenderer.h (right): https://codereview.chromium.org/318433003/diff/60001/tools/PictureRenderer.h#newcode264 tools/PictureRenderer.h:264: config.appendS32(fGridInfo.fTileInterval.fWidth); On 2014/06/03 18:46:33, ...
6 years, 6 months ago (2014-06-03 18:53:00 UTC) #3
jcgregorio
On 2014/06/03 18:53:00, kelvinly wrote: > Changed from fWidth/Height to width/height() > > https://codereview.chromium.org/318433003/diff/60001/tools/PictureRenderer.h > ...
6 years, 6 months ago (2014-06-03 20:46:18 UTC) #4
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-06-03 20:48:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/318433003/70001
6 years, 6 months ago (2014-06-03 20:48:31 UTC) #6
benchen
lgtm assuming local bench_pictures run succeeded with the change.
6 years, 6 months ago (2014-06-03 20:49:00 UTC) #7
kelvinly
The CQ bit was unchecked by kelvinly@google.com
6 years, 6 months ago (2014-06-03 22:20:44 UTC) #8
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-06-03 22:20:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/318433003/70001
6 years, 6 months ago (2014-06-03 22:20:52 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 22:43:38 UTC) #11
Message was sent while issue was closed.
Change committed as 06fdc6937df52942226a0a5e7bba169c27006ef1

Powered by Google App Engine
This is Rietveld 408576698