Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 31843003: IDL compiler: [MeasureAs] for setters (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M Source/bindings/templates/attributes.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 2 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years, 2 months ago (2013-10-21 07:06:43 UTC) #1
haraken
LGTM.
7 years, 2 months ago (2013-10-21 07:09:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/31843003/1
7 years, 2 months ago (2013-10-21 07:09:59 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-21 07:10:16 UTC) #4
Message was sent while issue was closed.
Change committed as 160067

Powered by Google App Engine
This is Rietveld 408576698