Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 318413002: Push API: define push event on Service Worker. (Closed)

Created:
6 years, 6 months ago by Michael van Ouwerkerk
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -4 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/modules.gypi View 4 chunks +6 lines, -0 lines 0 comments Download
A Source/modules/push_messaging/PushEvent.h View 1 chunk +51 lines, -0 lines 0 comments Download
A Source/modules/push_messaging/PushEvent.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
A + Source/modules/push_messaging/PushEvent.idl View 1 chunk +3 lines, -2 lines 0 comments Download
A Source/modules/push_messaging/ServiceWorkerGlobalScopePush.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 6 months ago (2014-06-09 16:53:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/318413002/1
6 years, 6 months ago (2014-06-09 16:54:47 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 17:23:28 UTC) #3
Message was sent while issue was closed.
Change committed as 175804

Powered by Google App Engine
This is Rietveld 408576698