Source/core/workers/WorkerThread.cpp - Issue 318393002: Initial implementation of ServiceWorkerGlobalScope.fetch()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerThread.cpp

Issue 318393002: Initial implementation of ServiceWorkerGlobalScope.fetch() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add test for destroying the execution context while fetch is happening. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/workers/WorkerThread.cpp

diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp

index 3d81fbe0afb9534b648e6b5426cf40a64f09469e..cbdaafee7aac6ae169392acc279708d4b6222a5b 100644

--- a/Source/core/workers/WorkerThread.cpp

+++ b/Source/core/workers/WorkerThread.cpp

@@ -205,6 +205,8 @@ public:

{

WorkerGlobalScope* workerGlobalScope = toWorkerGlobalScope(context);

+ workerGlobalScope->stopFetch();

dominicc (has gone to gerrit) 2014/06/16 06:07:50 Let's tighten up the whitespace here by deleting 2

horo 2014/06/16 06:32:18 Done.

workerGlobalScope->stopActiveDOMObjects();

// Event listeners would keep DOMWrapperWorld objects alive for too long. Also, they have references to JS objects,

« LayoutTests/http/tests/serviceworker/resources/fetch-worker.js ('K') | « Source/core/workers/WorkerGlobalScope.h ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »