[SyncFS] Create SyncWorkerInterface

[SyncFS] Create SyncWorkerInterface to inject SyncWorker.


BUG=347425, 378621
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276422

[peria, 2014-06-09 07:44:15]

PTL.

[tzik, 2014-06-09 08:04:23]

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_worker.h (right):

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker.h:26: #include
"webkit/browser/fileapi/file_system_url.h"
I think file_path, gurl and file_system_url can be converted to forward decl.

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h
(right):

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h:19:
#include "webkit/browser/fileapi/file_system_url.h"
Forward declarations seem to be able to replace some of #include.

[nhiroki, 2014-06-10 04:00:48]

LGTM after addressing tzik's comments.


nit: s/SynWorkerInterface/SyncWorkerInterface/ (in review title)

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_worker.h (right):

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker.h:95: const
SyncStatusCallback& callback) OVERRIDE;
nit: Can you make arguments of these functions aligned with ones of
UninstallOrigin()?

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h
(right):

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h:37: //
Initialize SyncWorkerInterface after constructions of some member classes.
nit: s/Initialize/Initializes/

[peria, 2014-06-10 04:31:08]

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_worker.h (right):

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker.h:26: #include
"webkit/browser/fileapi/file_system_url.h"
On 2014/06/09 08:04:23, tzik wrote:
> I think file_path, gurl and file_system_url can be converted to forward decl.

Done.

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker.h:95: const
SyncStatusCallback& callback) OVERRIDE;
On 2014/06/10 04:00:48, nhiroki wrote:
> nit: Can you make arguments of these functions aligned with ones of
> UninstallOrigin()?

Done.

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h
(right):

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h:19:
#include "webkit/browser/fileapi/file_system_url.h"
On 2014/06/09 08:04:23, tzik wrote:
> Forward declarations seem to be able to replace some of #include.

Done.

https://codereview.chromium.org/318353002/diff/90001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h:37: //
Initialize SyncWorkerInterface after constructions of some member classes.
On 2014/06/10 04:00:48, nhiroki wrote:
> nit: s/Initialize/Initializes/

Done.

[peria, 2014-06-11 03:41:05]

PTAL.
Rebase changes few files related to SyncEngine class.

[tzik, 2014-06-11 04:23:08]

https://codereview.chromium.org/318353002/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_worker.h (right):

https://codereview.chromium.org/318353002/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_worker.h:25: class
SyncStatusCallback;
This is a typedef name which can't be declared forward.

[tzik, 2014-06-11 04:26:17]

LGTM after addressing my comment.

[peria, 2014-06-11 04:45:09]

https://codereview.chromium.org/318353002/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_worker.h (right):

https://codereview.chromium.org/318353002/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_worker.h:25: class
SyncStatusCallback;
On 2014/06/11 04:23:07, tzik wrote:
> This is a typedef name which can't be declared forward.

Done.

[peria, 2014-06-11 04:45:13]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-11 04:49:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/318353002/160001

[tzik, 2014-06-11 04:52:53]

The CQ bit was unchecked by tzik@chromium.org

[peria, 2014-06-11 05:07:00]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-11 05:10:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/318353002/180001

[peria, 2014-06-11 05:28:27]

The CQ bit was unchecked by peria@chromium.org

[peria, 2014-06-11 05:38:02]

PTAL.
Add chrome_browser.gypi

[tzik, 2014-06-11 06:19:15]

lgtm

[peria, 2014-06-11 06:20:13]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-11 06:27:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/318353002/240001

[commit-bot: I haz the power, 2014-06-11 16:14:05]

Change committed as 276422