Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318343003: Move trace event based implementation parts of TimelineModel into TracingTimelineModel (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Move trace event based implementation parts of TimelineModel into TracingTimelineModel BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175790

Patch Set 1 #

Patch Set 2 : Fixed tests #

Patch Set 3 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -324 lines) Patch
M LayoutTests/inspector/layers/tracing-layer-tree.html View 1 1 chunk +1 line, -5 lines 0 comments Download
M LayoutTests/inspector/timeline/trace-event-self-time.html View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M LayoutTests/inspector/timeline/tracing/decode-resize.html View 1 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/tracing/frame-model.html View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/inspector/tracing-test.js View 1 1 chunk +13 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 5 chunks +3 lines, -267 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 7 chunks +20 lines, -26 lines 4 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 2 5 chunks +285 lines, -10 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 6 months ago (2014-06-09 08:50:13 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-09 11:40:17 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-09 11:41:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/318343003/40001
6 years, 6 months ago (2014-06-09 11:41:40 UTC) #4
caseq
https://codereview.chromium.org/318343003/diff/40001/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/318343003/diff/40001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode208 Source/devtools/front_end/timeline/TimelinePanel.js:208: if (minimumRecordTime && minimumRecordTime != -1) !==? https://codereview.chromium.org/318343003/diff/40001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode221 Source/devtools/front_end/timeline/TimelinePanel.js:221: ...
6 years, 6 months ago (2014-06-09 11:59:03 UTC) #5
yurys
https://codereview.chromium.org/318343003/diff/40001/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/318343003/diff/40001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode208 Source/devtools/front_end/timeline/TimelinePanel.js:208: if (minimumRecordTime && minimumRecordTime != -1) On 2014/06/09 11:59:03, ...
6 years, 6 months ago (2014-06-09 12:16:13 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 12:43:53 UTC) #7
Message was sent while issue was closed. 
Change committed as 175790

Powered by Google App Engine
This is Rietveld 408576698