Issue 3183019: Mac: Fix leak in tabpose.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3183019: Mac: Fix leak in tabpose. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Nico

Modified:
4 years ago

Reviewers:
Robert Sesek, jochen, viettrungluu

CC:
chromium-reviews, Alexander Potapenko, ben+cc_chromium.org, John Grabowski, Timur Iskhodzhanov, pam+watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Visibility:
Public.

Description

Mac: Fix leak in tabpose. BUG=51786 TEST=valgrind stays green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56730

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -11 lines)			Patch
M	base/scoped_vector.h	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	chrome/browser/cocoa/tabpose_window.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Trybot results: linux_valgrind linux mac win mac_valgrind

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

lgtm http://codereview.chromium.org/3183019/diff/1/2 File base/scoped_vector.h (right): http://codereview.chromium.org/3183019/diff/1/2#newcode30 base/scoped_vector.h:30: T*& operator[](size_t i) { return v[i]; } Wow, ...

4 years, 9 months ago (2010-08-19 18:57:44 UTC) #2

Robert Sesek

4 years, 9 months ago (2010-08-19 19:05:14 UTC) #3

LGTM.  Sorry for the delay; I had intern-y things to do.

Expand Messages | Collapse Messages