Issue 318263002: Revert "Call insertedInto or removedFrom before childrenChanged"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318263002: Revert "Call insertedInto or removedFrom before childrenChanged" (Closed)

Created:
6 years, 6 months ago by dcheng

Modified:
6 years, 6 months ago

Reviewers:
esprehn

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis, ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Call insertedInto or removedFrom before childrenChanged" This reverts commit ebab27e4fe728206d3be9a54fd66ca99de12a298. Revert "Oilpan: fix build after r175732." This reverts commit 1838d888958380a6e51de4d677665bd204bd5134. Breaks plugins/document-open.html TBR=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175750

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -35 lines)			Patch
	M	Source/core/dom/ContainerNode.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	Source/core/dom/ContainerNode.cpp	View		10 chunks	+25 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dcheng

Committed patchset #1 manually as r175750 (presubmit successful).

6 years, 6 months ago (2014-06-07 19:39:36 UTC) #1

esprehn

On 2014/06/07 19:39:36, dcheng wrote: > Committed patchset #1 manually as r175750 (presubmit successful). Where ...

6 years, 6 months ago (2014-06-07 19:48:11 UTC) #2

dcheng

6 years, 6 months ago (2014-06-07 20:14:28 UTC) #3

Message was sent while issue was closed.

On 2014/06/07 19:48:11, esprehn wrote:
> On 2014/06/07 19:39:36, dcheng wrote:
> > Committed patchset #1 manually as r175750 (presubmit successful).
> 
> Where is this failing on the bots? Please link to failures and stacks when
> reverting.

Sorry, I've been trying to roll the tree over Chromoting and Android (long
story) so typing a lot has been painful.

Example failure:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%2...

The stack is >10kb so I can't paste it inline here. I spent a bit trying to trim
it but gave up.

Expand Messages | Collapse Messages