Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318253002: Revert the revert in https://codereview.chromium.org/323713002/ and fix the bug. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-07 15:32:36 UTC) #1
tonyg
lgtm
6 years, 6 months ago (2014-06-07 15:33:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/318253002/1
6 years, 6 months ago (2014-06-07 15:34:53 UTC) #3
tonyg
The CQ bit was unchecked by tonyg@chromium.org
6 years, 6 months ago (2014-06-07 15:35:48 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-07 15:35:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/318253002/1
6 years, 6 months ago (2014-06-07 15:36:03 UTC) #6
nednguyen
The CQ bit was unchecked by nednguyen@google.com
6 years, 6 months ago (2014-06-07 15:36:51 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-07 15:36:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/318253002/1
6 years, 6 months ago (2014-06-07 15:36:55 UTC) #9
commit-bot: I haz the power
Change committed as 275690
6 years, 6 months ago (2014-06-07 16:02:53 UTC) #10
achuithb
On 2014/06/07 16:02:53, I haz the power (commit-bot) wrote: > Change committed as 275690 Cros ...
6 years, 6 months ago (2014-06-09 19:07:53 UTC) #11
nednguyen
6 years, 6 months ago (2014-06-09 19:51:15 UTC) #12
Message was sent while issue was closed. 
On 2014/06/09 19:07:53, achuithb wrote:
> On 2014/06/07 16:02:53, I haz the power (commit-bot) wrote:
> > Change committed as 275690
> 
> Cros tree is closed:
>
https://code.google.com/p/chromium/issues/list?can=2&q=AttributeError%3A+%27I...
> 
> Stack:
> Traceback (most recent call last):
>     File "/usr/local/autotest/common_lib/test.py", line 725, in
> _call_test_function
>       return func(*args, **dargs)
>     File "/usr/local/autotest/common_lib/test.py", line 386, in execute
>       dargs)
>     File "/usr/local/autotest/common_lib/test.py", line 275, in
> _call_run_once_with_retry
>       postprocess_profiled_run, args, dargs)
>     File "/usr/local/autotest/common_lib/test.py", line 304, in _call_run_once
>       self.run_once(*args, **dargs)
>     File
>
"/usr/local/autotest/tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py",
> line 102, in run_once
>       self.run_performance_test(cr.browser, test_url)
>     File
>
"/usr/local/autotest/tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py",
> line 56, in run_performance_test
>       'Timed out running the test.')
>     File
>
"/usr/local/autotest/tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py",
> line 37, in poll_for_condition
>       sleep_interval=1)
>     File "/usr/local/autotest/bin/site_utils.py", line 178, in
> poll_for_condition
>       value = condition()
>     File
>
"/usr/local/autotest/tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py",
> line 34, in <lambda>
>       lambda: tab.EvaluateJavaScript(condition),
>     File
> "/usr/local/telemetry/src/tools/telemetry/telemetry/core/web_contents.py",
line
> 103, in EvaluateJavaScript
>       expr, context_id=None, timeout=timeout)
>     File
> "/usr/local/telemetry/src/tools/telemetry/telemetry/core/web_contents.py",
line
> 119, in EvaluateJavaScriptInContext
>       expr, context_id=context_id, timeout=timeout)
>     File
>
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py",
> line 172, in EvaluateJavaScript
>       return self._runtime.Evaluate(expr, context_id, timeout)
>     File
>
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py",
> line 35, in Evaluate
>       res = self._inspector_backend.SyncRequest(request, timeout)
>     File
>
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py",
> line 62, in SyncRequest
>       res = self._Receive(timeout)
>     File
>
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py",
> line 108, in _Receive
>       self._error_handler(elapsed_time)
>     File
>
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py",
> line 238, in _HandleError
>       if self._IsInspectable():
>     File
>
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py",
> line 215, in _IsInspectable
>       return self.id in [c['id'] for c in contexts]
>   AttributeError: 'InspectorBackend' object has no attribute 'id'
> 
> I believe we need to cherry-pick this CL into the chrome branch and we should
be
> good - correct me if I'm wrong, Ned/Tony?

Yes, I think this should fix the bug.

Powered by Google App Engine
This is Rietveld 408576698