Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 318243002: Revert of Revert of Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, wjia+watch_chromium.org, vignatti (out of this project)
Visibility:
Public.

Description

Revert of Revert of Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator (https://codereview.chromium.org/319323002/) Reason for revert: Relanding since the failure appears to be unrelated. Original issue's description: > Revert of Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator (https://codereview.chromium.org/317083003/) > > Reason for revert: > Speculative revert to fix content_unittest failures in http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20807 > > Original issue's description: > > Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator > > > > This moves the single method CanDecodeOnIOThread on > > VideoDecodeAcceleratorImpl to VideoDecodeAccelerator. The > > implementations that were subclasses of VideoDecodeAcceleratorImpl now > > get an override for CanDecodeOnIOThread that returns false. > > > > TEST=linux desktop build > > BUG=380884 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275621 > > TBR=scherkus@chromium.org,fischman@chromium.org,spang@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=380884 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275636 TBR=scherkus@chromium.org,fischman@chromium.org,spang@chromium.org NOTREECHECKS=true NOTRY=true BUG=380884 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -79 lines) Patch
M content/common/gpu/media/android_video_decode_accelerator.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
D content/common/gpu/media/video_decode_accelerator_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/common/gpu/media/video_decode_accelerator_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/mock_video_decode_accelerator.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 chunk +11 lines, -0 lines 0 comments Download
M media/video/video_decode_accelerator.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Revert of Merge VideoDecodeAcceleratorImpl with VideoDecodeAccelerator
6 years, 6 months ago (2014-06-07 08:20:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/318243002/1
6 years, 6 months ago (2014-06-07 08:21:39 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 09:13:54 UTC) #3
Message was sent while issue was closed.
Change committed as 275669

Powered by Google App Engine
This is Rietveld 408576698