Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7488)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix trybot errors (memory leak + unused code) Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index c29256108b7672f7e8b70fce08cfb76583f90b4f..5297c524d69afbff29c3cb4e3b2d0ae53eaeaa50 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -331,8 +331,7 @@ SSLBlockingPage::SSLBlockingPage(content::WebContents* web_contents,
callback_(callback),
cert_error_(cert_error),
ssl_info_(ssl_info),
- overridable_(options_mask & OVERRIDABLE &&
- !(options_mask & STRICT_ENFORCEMENT)),
+ overridable_(IsOverridable(options_mask)),
danger_overridable_(true),
strict_enforcement_((options_mask & STRICT_ENFORCEMENT) != 0),
internal_(false),
@@ -721,6 +720,12 @@ void SSLBlockingPage::SetExtraInfo(
}
}
+// static
+bool SSLBlockingPage::IsOverridable(int options_mask) {
+ return (options_mask & SSLBlockingPage::OVERRIDABLE) &&
+ !(options_mask & SSLBlockingPage::STRICT_ENFORCEMENT);
+}
+
void SSLBlockingPage::OnGotHistoryCount(bool success,
int num_visits,
base::Time first_visit) {

Powered by Google App Engine
This is Rietveld 408576698