Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4549)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Expand browser tests Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/captive_portal_blocking_page.h
diff --git a/chrome/browser/ssl/captive_portal_blocking_page.h b/chrome/browser/ssl/captive_portal_blocking_page.h
new file mode 100644
index 0000000000000000000000000000000000000000..56df6fa7c6793b75314f489432bd7a5eb86da583
--- /dev/null
+++ b/chrome/browser/ssl/captive_portal_blocking_page.h
@@ -0,0 +1,51 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
+#define CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "chrome/browser/interstitials/security_interstitial_page.h"
+
+class GURL;
+
+namespace content{
+class WebContents;
+}
+
+// This class is responsible for showing/hiding the interstitial page that is
+// shown when a captive portal and an SSL error is detected.
+// It deletes itself when the interstitial page is closed.
+//
+// This class should only be used on the UI thread because its implementation
+// uses captive_portal::CaptivePortalService, which can only be accessed on the
+// UI thread.
mmenke 2014/12/09 22:42:26 + "Only used when ENABLE_CAPTIVE_PORTAL_DETECTION
meacer 2014/12/10 22:48:02 Done.
+class CaptivePortalBlockingPage : public SecurityInterstitialPage {
+ public:
+ // Interstitial type, for testing.
+ static const void* kTypeForTesting;
+
+ CaptivePortalBlockingPage(content::WebContents* web_contents,
+ const GURL& request_url);
+ ~CaptivePortalBlockingPage() override;
+
+ // SecurityInterstitialPage method:
+ const void* GetTypeForTesting() const override;
+
+ protected:
+ // SecurityInterstitialPage implementation:
mmenke 2014/12/09 22:42:26 nit: Should be consistent. You use "method:" abo
meacer 2014/12/10 22:48:02 Done.
+ void PopulateInterstitialStrings(
+ base::DictionaryValue* load_time_data) override;
+ bool ShouldCreateNewNavigation() const override;
+
+ // InterstitialPageDelegate implementation.
+ void CommandReceived(const std::string& command) override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
+};
+
+#endif // CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_

Powered by Google App Engine
This is Rietveld 408576698