Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/captive_portal/captive_portal_service.cc

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Expand browser tests Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/captive_portal/captive_portal_service.cc
diff --git a/chrome/browser/captive_portal/captive_portal_service.cc b/chrome/browser/captive_portal/captive_portal_service.cc
index 93c37a8c1b81f69c8f9c174e934e7a1276f8a3bd..fa83508caad112cb6a22ade1cc9a915fc7dbd67e 100644
--- a/chrome/browser/captive_portal/captive_portal_service.cc
+++ b/chrome/browser/captive_portal/captive_portal_service.cc
@@ -194,7 +194,8 @@ CaptivePortalService::CaptivePortalService(Profile* profile)
enabled_(false),
last_detection_result_(captive_portal::RESULT_INTERNET_CONNECTED),
num_checks_with_same_result_(0),
- test_url_(captive_portal::CaptivePortalDetector::kDefaultURL) {
+ test_url_(captive_portal::CaptivePortalDetector::kDefaultURL),
+ portal_detection_enabled_(true) {
// The order matters here:
// |resolve_errors_with_web_service_| must be initialized and |backoff_entry_|
// created before the call to UpdateEnabledState.
@@ -211,9 +212,17 @@ CaptivePortalService::CaptivePortalService(Profile* profile)
CaptivePortalService::~CaptivePortalService() {
}
+void CaptivePortalService::SetPortalDetectionEnabledForTest(bool enabled) {
+ portal_detection_enabled_ = enabled;
+}
+
void CaptivePortalService::DetectCaptivePortal() {
DCHECK(CalledOnValidThread());
+ // Detection should be disabled only in tests.
+ if (!portal_detection_enabled_)
+ return;
+
// If a request is pending or running, do nothing.
if (state_ == STATE_CHECKING_FOR_PORTAL || state_ == STATE_TIMER_RUNNING)
return;

Powered by Google App Engine
This is Rietveld 408576698