Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2449)

Unified Diff: chrome/browser/ssl/ssl_error_handler.cc

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Stop the timer at the right place Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_error_handler.cc
diff --git a/chrome/browser/ssl/ssl_error_handler.cc b/chrome/browser/ssl/ssl_error_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ac6165ec5c04011c199f788f2a45c6b8341d1226
--- /dev/null
+++ b/chrome/browser/ssl/ssl_error_handler.cc
@@ -0,0 +1,183 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ssl/ssl_error_handler.h"
+
+#include "base/metrics/histogram.h"
+#include "base/time/time.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ssl/ssl_blocking_page.h"
+#include "chrome/common/chrome_version_info.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/browser/web_contents.h"
+
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+#include "chrome/browser/captive_portal/captive_portal_service.h"
+#include "chrome/browser/captive_portal/captive_portal_service_factory.h"
+#include "chrome/browser/captive_portal/captive_portal_tab_helper.h"
+#include "chrome/browser/ssl/captive_portal_blocking_page.h"
+#endif
+
+namespace {
+
+// Events for UMA.
+enum SSLErrorHandlerEvent {
+ HANDLE_ALL,
+ CAPTIVE_PORTAL_CHECK,
+ SHOW_CAPTIVE_PORTAL_INTERSTITIAL,
+ SHOW_CAPTIVE_PORTAL_INTERSTITIAL_OVERRIDABLE,
+ SHOW_SSL_INTERSTITIAL,
+ SHOW_SSL_INTERSTITIAL_OVERRIDABLE,
+ SSL_ERROR_HANDLER_EVENT_COUNT
+};
+
+void RecordUMA(SSLErrorHandlerEvent event) {
+ UMA_HISTOGRAM_ENUMERATION("interstitial.ssl_error_handler",
+ event,
+ SSL_ERROR_HANDLER_EVENT_COUNT);
+}
+
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+bool IsCaptivePortalInterstitialEnabled() {
+ chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
+ return channel <= chrome::VersionInfo::CHANNEL_DEV;
+}
+#endif
+
+} // namespace
+
+SSLErrorHandler::SSLErrorHandler(content::WebContents* web_contents,
+ int cert_error,
+ const net::SSLInfo& ssl_info,
+ const GURL& request_url,
+ const int options_mask,
+ const base::TimeDelta ssl_error_delay,
+ const base::Callback<void(bool)>& callback)
+ : content::WebContentsObserver(web_contents),
+ web_contents_(web_contents),
+ cert_error_(cert_error),
+ ssl_info_(ssl_info),
+ request_url_(request_url),
+ options_mask_(options_mask),
+ callback_(callback),
+ ssl_interstitial_display_delay_(ssl_error_delay) {
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+ Profile* profile = Profile::FromBrowserContext(
+ web_contents_->GetBrowserContext());
+ registrar_.Add(this,
+ chrome::NOTIFICATION_CAPTIVE_PORTAL_CHECK_RESULT,
+ content::Source<Profile>(profile));
+#endif
+}
+
+SSLErrorHandler::~SSLErrorHandler() {
+}
+
+void SSLErrorHandler::HandleSSLError(
+ content::WebContents* web_contents,
+ int cert_error,
+ const net::SSLInfo& ssl_info,
+ const GURL& request_url,
+ int options_mask,
+ const base::Callback<void(bool)>& callback) {
+ // SSL interstitials aren't delayed if captive portal detection is disabled.
+ base::TimeDelta ssl_error_delay;
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+ CaptivePortalTabHelper* captive_portal_tab_helper =
+ CaptivePortalTabHelper::FromWebContents(web_contents);
+ if (captive_portal_tab_helper) {
+ captive_portal_tab_helper->OnSSLCertError(ssl_info);
+ ssl_error_delay = captive_portal_tab_helper->GetSSLErrorDelay();
mmenke 2014/11/10 17:32:08 I need to spend some time thinking about how to mo
+ }
+#endif
+ (new SSLErrorHandler(web_contents, cert_error, ssl_info, request_url,
mmenke 2014/11/10 17:32:08 nit: +1 indent
meacer 2014/11/14 00:30:25 Done.
+ options_mask, ssl_error_delay, callback))->Handle();
+}
+
+void SSLErrorHandler::Handle() {
+ RecordUMA(HANDLE_ALL);
+
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+ if (IsCaptivePortalInterstitialEnabled()) {
+ CheckForCaptivePortal();
+ timer_.Start(FROM_HERE, ssl_interstitial_display_delay_,
+ base::Bind(&SSLErrorHandler::OnTimerExpired,
+ base::Unretained(this)));
+ return;
+ }
+#endif
+ // Display an SSL interstitial.
+ ShowSSLInterstitial();
+}
+
+void SSLErrorHandler::CheckForCaptivePortal() {
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+ RecordUMA(CAPTIVE_PORTAL_CHECK);
mmenke 2014/11/10 17:32:08 Do we get anything out of this histogram? Basical
meacer 2014/11/14 00:30:25 Mostly convenience. With this one doesn't need to
meacer 2014/11/14 00:31:32 Actually, I'll probably delete this histogram.
+ Profile* profile = Profile::FromBrowserContext(
+ web_contents_->GetBrowserContext());
+ CaptivePortalService* captive_portal_service =
+ CaptivePortalServiceFactory::GetForProfile(profile);
+ captive_portal_service->DetectCaptivePortal();
+#endif
+}
+
+void SSLErrorHandler::ShowCaptivePortalInterstitial() {
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+ // Show captive portal blocking page. The interstitial owns the blocking page.
+ RecordUMA(SSLBlockingPage::IsOverridable(options_mask_) ?
+ SHOW_CAPTIVE_PORTAL_INTERSTITIAL_OVERRIDABLE :
+ SHOW_CAPTIVE_PORTAL_INTERSTITIAL);
+ (new CaptivePortalBlockingPage(web_contents_, request_url_))->Show();
+ delete this;
+#else
+ NOTREACHED();
+#endif
+}
+
+void SSLErrorHandler::ShowSSLInterstitial() {
+ // Show SSL blocking page. The interstitial owns the blocking page.
+ RecordUMA(SSLBlockingPage::IsOverridable(options_mask_) ?
+ SHOW_SSL_INTERSTITIAL_OVERRIDABLE :
+ SHOW_SSL_INTERSTITIAL);
+ (new SSLBlockingPage(web_contents_, cert_error_, ssl_info_, request_url_,
+ options_mask_, callback_))->Show();
+ delete this;
+}
+
+void SSLErrorHandler::OnTimerExpired() {
+ ShowSSLInterstitial();
+}
+
+void SSLErrorHandler::Observe(
+ int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
+#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+ if (type == chrome::NOTIFICATION_CAPTIVE_PORTAL_CHECK_RESULT) {
+ timer_.Stop();
+ CaptivePortalService::Results* results =
+ content::Details<CaptivePortalService::Results>(details).ptr();
+ if (results->result == captive_portal::RESULT_BEHIND_CAPTIVE_PORTAL)
+ ShowCaptivePortalInterstitial();
+ else
+ ShowSSLInterstitial();
+ }
+#endif
+}
+
+void SSLErrorHandler::DidStartNavigationToPendingEntry(
+ const GURL& url,
+ content::NavigationController::ReloadType reload_type) {
+ delete this;
+}
+
+void SSLErrorHandler::DidStopLoading(
+ content::RenderViewHost* render_view_host) {
+ delete this;
+}
+
+void SSLErrorHandler::WebContentsDestroyed() {
+ delete this;
+}

Powered by Google App Engine
This is Rietveld 408576698