Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper.h

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android tests, add more uma, address mmenke's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/captive_portal/captive_portal_tab_helper.h
diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.h b/chrome/browser/captive_portal/captive_portal_tab_helper.h
index 421afcd8efab82ef75f48016825c1925d931ba06..9b05ef21620a29d6ba100ee3cbd082599bc4b415 100644
--- a/chrome/browser/captive_portal/captive_portal_tab_helper.h
+++ b/chrome/browser/captive_portal/captive_portal_tab_helper.h
@@ -108,6 +108,9 @@ class CaptivePortalTabHelper
// page. This is set to false when a captive portal is no longer detected.
bool IsLoginTab() const;
+ // Opens a login tab if the profile's active window doesn't have one already.
+ void OpenLoginTab(bool focus);
mmenke 2014/06/20 16:07:08 optional: Could make this something like: static
meacer 2014/06/20 23:28:14 Done.
+
private:
friend class CaptivePortalBrowserTest;
friend class CaptivePortalTabHelperTest;
@@ -140,9 +143,6 @@ class CaptivePortalTabHelper
CaptivePortalTabReloader* GetTabReloaderForTest();
- // Opens a login tab if the profile's active window doesn't have one already.
- void OpenLoginTab();
-
Profile* profile_;
// Neither of these will ever be NULL.

Powered by Google App Engine
This is Rietveld 408576698