Chromium Code Reviews Chromium Code Reviews
Issue 318213002:
Add custom interstitial for captive portals. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index ec529049703cfccd23ae4be1a2e45c7019f1748b..af6d96083a667c98fe153adff48530e99ff6884b 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -11269,6 +11269,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="interstitial.captive_portal" |
| + enum="CaptivePortalBlockingPageEvent"> |
| + <owner>meacer@chromium.org</owner> |
| + <summary> |
| + User action when the user is shown a captive portal error page. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="interstitial.common_name_invalid_time" units="milliseconds"> |
| <obsolete> |
| Removed on 8/1/13. |
| @@ -11470,6 +11478,11 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="interstitial.ssl_error_handler" enum="SSLErrorHandlerEvent"> |
| + <owner>meacer@chromium.org</owner> |
| + <summary>The type of action that the SSL error handler takes.</summary> |
| +</histogram> |
| + |
| <histogram name="interstitial.ssl_error_type" enum="SSLErrorTypes"> |
| <owner>felt@chromium.org</owner> |
| <summary> |
| @@ -42788,6 +42801,11 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <int value="3" label="webgl"/> |
| </enum> |
| +<enum name="CaptivePortalBlockingPageEvent" type="int"> |
| + <int value="0" label="SHOW_ALL"/> |
| + <int value="1" label="OPEN_LOGIN_PAGE"/> |
| +</enum> |
| + |
| <enum name="CaptivePortalDetectResult" type="int"> |
| <int value="0" label="INTERNET_CONNECTED"/> |
| <int value="1" label="NO_RESPONSE"/> |
| @@ -56632,6 +56650,14 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="49323" label="TLS_PSK_DHE_WITH_AES_256_CCM_8"/> |
| </enum> |
| +<enum name="SSLErrorHandlerEvent" type="int"> |
| + <int value="0" label="HANDLE_ALL"/> |
|
felt
2014/12/28 15:40:52
Can the label make it clear that this is the total
meacer
2015/01/08 14:29:16
Does making the distinction between nonoverridable
|
| + <int value="1" label="SHOW_CAPTIVE_PORTAL_INTERSTITIAL"/> |
| + <int value="2" label="SHOW_CAPTIVE_PORTAL_INTERSTITIAL_OVERRIDABLE"/> |
| + <int value="3" label="SHOW_SSL_INTERSTITIAL"/> |
| + <int value="4" label="SHOW_SSL_INTERSTITIAL_OVERRIDABLE"/> |
| +</enum> |
| + |
| <enum name="SSLErrorTypes" type="int"> |
| <int value="0" label="CERT_COMMON_NAME_INVALID"/> |
| <int value="1" label="CERT_DATE_INVALID"/> |
