Add custom interstitial for captive portals.

chrome/browser/ssl/ssl_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 25 matching lines @@
   enum SSLBlockingPageCommands {
     CMD_DONT_PROCEED = 0,
     CMD_PROCEED = 1,
     CMD_MORE = 2,
     CMD_RELOAD = 3,
     CMD_HELP = 4,
     CMD_CLOCK = 5
   };
 
   enum SSLBlockingPageOptionsMask {
+    // Indicates whether or not the user could (assuming perfect knowledge)
+    // successfully override the error and still get the security guarantees
+    // of TLS.
     OVERRIDABLE = 1 << 0,
+    // Indicates whether or not the site the user is trying to connect to has
+    // requested strict enforcement of certificate validation (e.g. with HTTP
+    // Strict-Transport-Security).
     STRICT_ENFORCEMENT = 1 << 1,
+    // Indicates whether a user decision had been previously made but the
+    // decision has expired.
     EXPIRED_BUT_PREVIOUSLY_ALLOWED = 1 << 2
   };
 
   // Interstitial type, used in tests.
   static const void* kTypeForTesting;
 
   ~SSLBlockingPage() override;
 
   // Creates an SSL blocking page. If the blocking page isn't shown, the caller
   // is responsible for cleaning up the blocking page, otherwise the
   // interstitial takes ownership when shown. |options_mask| must be a bitwise
   // mask of SSLBlockingPageOptionsMask values.
   SSLBlockingPage(content::WebContents* web_contents,
                   int cert_error,
                   const net::SSLInfo& ssl_info,
                   const GURL& request_url,
                   int options_mask,
                   const base::Callback<void(bool)>& callback);
 
   // SecurityInterstitialPage method:
   const void* GetTypeForTesting() const override;
 
   // A method that sets strings in the specified dictionary from the passed
   // vector so that they can be used to resource the ssl_roadblock.html/
   // ssl_error.html files.
   // Note: there can be up to 5 strings in |extra_info|.
   static void SetExtraInfo(base::DictionaryValue* strings,
                            const std::vector<base::string16>& extra_info);
 
+  static bool IsOverridable(int options_mask);

[felt, 2014/12/28 15:40:52]

At first I expected this to be a getter for overridable_, but now I see that
it's static and used to calculate the value of overridable_. Can you either
rename to CalculateIsOverridable or add a comment explaining?

[meacer, 2015/01/08 14:29:16]

Calculate seemed to not imply that it returns bool, so renamed to
IsOptionsOverridable and added a comment. 

+
  protected:
   // InterstitialPageDelegate implementation.
   void CommandReceived(const std::string& command) override;
   void OverrideEntry(content::NavigationEntry* entry) override;
   void OverrideRendererPrefs(content::RendererPreferences* prefs) override;
   void OnProceed() override;
   void OnDontProceed() override;
 
   // SecurityInterstitialPage implementation:
   bool ShouldCreateNewNavigation() const override;
@@ skipping 38 matching lines @@
   // For Chrome Experience Sampling Platform: this maintains event state.
   scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
 #endif
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_