Add custom interstitial for captive portals.

chrome/browser/ssl/ssl_error_handler.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[mmenke, 2014/06/24 18:09:27]

nit:  --(c)

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SSL_SSL_ERROR_HANDLER_H_
+#define CHROME_BROWSER_SSL_SSL_ERROR_HANDLER_H_
+
+#include <string>
+
+#include "base/callback_forward.h"
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/timer/timer.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "net/ssl/ssl_info.h"
+#include "url/gurl.h"
+
+namespace content {
+class RenderViewHost;
+class WebContents;
+}
+
+// This class is responsible for deciding whether to show an SSL warning or a
+// captive portal error page.
+// It deletes itself when the interstitial page is closed.
+//
+// This class should only be used on the UI thread because its implementation
+// uses captive_portal::CaptivePortalService which can only be accessed on the
+// UI thread.
+class SSLErrorHandler : public content::WebContentsObserver,
+                        public content::NotificationObserver {
+ public:
+  SSLErrorHandler(content::WebContents* web_contents,
+                  int cert_error,
+                  const net::SSLInfo& ssl_info,
+                  const GURL& request_url,
+                  bool overridable,
+                  bool strict_enforcement,
+                  const base::Callback<void(bool)>& callback);
+  virtual ~SSLErrorHandler();
+
+  void Handle();
+  virtual void OnCaptivePortalResult();
+  virtual void OnTimerExpired();

[mmenke, 2014/06/24 18:09:27]

Suggest moving these down to the protected section, and having the test fixture
expose them.  Also, I don't believe they need to be virtual.

+  bool handled() const { return handled_; }
+
+ protected:
+  // Only used in tests.
+  void set_ssl_interstitial_display_delay(base::TimeDelta delay) {
+    ssl_interstitial_display_delay_ = delay;
+  }
+  base::OneShotTimer<SSLErrorHandler> timer_;

[mmenke, 2014/06/24 18:09:27]

Rather than making timer_ protected (Which Google style guide technically
forbids), suggest making it private, and making a protected method
IsTimerRunning.  Then just have the test fixture expose that.

[meacer, 2014/10/22 23:04:29]

Done.

+
+ private:
+  // content::WebContentsObserver:
+  virtual void DidStopLoading(
+      content::RenderViewHost* render_view_host) OVERRIDE;
+  virtual void WebContentsDestroyed() OVERRIDE;
+
+  // content::NotificationObserver:
+  virtual void Observe(
+      int type,
+      const content::NotificationSource& source,
+      const content::NotificationDetails& details) OVERRIDE;
+
+  virtual void ShowSSLInterstitial();
+  virtual void ShowCaptivePortalInterstitial();
+  virtual void CheckForCaptivePortal();
+
+  content::WebContents* web_contents_;
+  const int cert_error_;
+  const net::SSLInfo ssl_info_;
+  const GURL request_url_;
+  const bool overridable_;
+  const bool strict_enforcement_;
+  const base::Callback<void(bool)> callback_;
+  bool handled_;
+
+  // Time to wait before displaying the SSL interstitial. If a captive portal
+  // arrives before this, the captive portal interstitial is displayed instead.
+  base::TimeDelta ssl_interstitial_display_delay_;
+
+  content::NotificationRegistrar registrar_;
+
+  DISALLOW_COPY_AND_ASSIGN(SSLErrorHandler);
+};
+
+#endif  // CHROME_BROWSER_SSL_SSL_ERROR_HANDLER_H_