Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Const all the things Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
mmenke 2014/06/24 18:09:26 nit: New files shouldn't use the (c)
meacer 2014/10/22 23:04:28 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
6 #define CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
7
8 #include <string>
9
10 #include "base/macros.h"
11 #include "content/public/browser/interstitial_page_delegate.h"
12 #include "url/gurl.h"
13
14 namespace content {
15 class InterstitialPage;
16 class WebContents;
17 }
18
19 // This class is responsible for showing/hiding the interstitial page that is
20 // shown when a captive portal and an SSL error is detected.
21 // It deletes itself when the interstitial page is closed..
mmenke 2014/06/24 18:09:26 nit: Remove extra period
meacer 2014/10/22 23:04:29 Done.
22 //
23 // This class should only be used on the UI thread because WebContents should
24 // not be access on any other thread.
25 class CaptivePortalBlockingPage : public content::InterstitialPageDelegate {
26 public:
27 CaptivePortalBlockingPage(content::WebContents* web_contents,
28 const GURL& request_url);
29 virtual ~CaptivePortalBlockingPage();
30
31 protected:
mmenke 2014/06/24 18:09:26 optional: These can all be private instead. Or p
meacer 2014/10/22 23:04:29 Done.
32 // InterstitialPageDelegate implementation.
33 virtual std::string GetHTMLContents() OVERRIDE;
34 virtual void CommandReceived(const std::string& command) OVERRIDE;
35
36 private:
37 content::WebContents* web_contents_;
38 // The URL which had the SSL error.
39 const GURL request_url_;
40 // The interstitial page owns us.
mmenke 2014/06/24 18:09:26 nit: Don't use "us" in comments, as it can be amb
meacer 2014/10/22 23:04:29 Done.
41 content::InterstitialPage* interstitial_page_;
42
43 DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
44 };
45
46 #endif // CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698