chrome/browser/resources/ssl/captive_portal.html - Issue 318213002: Add custom interstitial for captive portals.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/ssl/captive_portal.html

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Const all the things Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/captive_portal/captive_portal_tab_helper.cc ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/resources/ssl/captive_portal.js » ('j') | chrome/browser/ssl/captive_portal_blocking_page.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html i18n-values="dir:textdirection;.style.fontSize:fontsize">

	3 <head>
	mmenke 2014/06/24 18:09:26 I wonder if we can just reuse interstitial_v2.html I wonder if we can just reuse interstitial_v2.html, hiding the elements we don't use? May even be able to share the C++ files, just use different strings and adding different functions. Or could make them share a parent class or something. My concern is just minimizing redundant HTML, and making updating neterror.css less of a pain. meacer 2014/10/22 23:04:28 Done. I refactored security interstitials to share Show quoted text On 2014/06/24 18:09:26, mmenke wrote: > I wonder if we can just reuse interstitial_v2.html, hiding the elements we don't > use? May even be able to share the C++ files, just use different strings and > adding different functions. Or could make them share a parent class or > something. > > My concern is just minimizing redundant HTML, and making updating neterror.css > less of a pain. Done. I refactored security interstitials to share some code in https://codereview.chromium.org/622683006/. This CL depends on that, and all interstitials use the same template now.
	4 <meta charset="utf-8">

	5 <meta name="viewport" content="width=device-width, initial-scale=1.0,

	6 maximum-scale=1.0, user-scalable=no">

	7 <title i18n-content="title"></title>

	8 <link rel="stylesheet" href="../../../renderer/resources/neterror.css">

	9 <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>

	10 <script src="../../../../ui/webui/resources/js/util.js"></script>

	11 <script src="captive_portal.js"></script>

	12 </head>

	13 <body>

	14 <div id="main-frame-error">

	15 <div id="box">

	16 <div id="content-top">

	17 <h1>

	18 <div>

	19 <img class="icon icon-offline">

	20 </div>

	21 <span i18n-content="heading"></span>

	22 </h1>

	23 <p i18n-values=".innerHTML:primaryParagraph"></p>

	24 <div id="buttons">

	25 <button class="blue-button text-button"

	26 id="primary-button" i18n-content="primaryButtonText"></button>

	27 <button id="details-button" class="text-button"

	28 i18n-content="openDetails"></button>

	29 </div>

	30

	31 <div id="details" class="hidden">

	32 <p i18n-values=".innerHTML:explanationParagraph"></p>

	33 </div>

	34 </div>

	35 </div>

	36 </div>

	37 </body>

	38 </html>

OLD	NEW