Make MetricsService save compressed logs to local state.

components/metrics/compression_utils_unittest.cc

Index: components/metrics/compression_utils_unittest.cc
===================================================================
--- components/metrics/compression_utils_unittest.cc	(working copy)
+++ components/metrics/compression_utils_unittest.cc	(working copy)
@@ -2,14 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "components/metrics/net/compression_utils.h"
+#include "components/metrics/compression_utils.h"
 
 #include <string>
 
-#include "base/base_paths.h"
 #include "base/basictypes.h"
-#include "base/file_util.h"
-#include "base/path_service.h"
+#include "base/rand_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace metrics {
@@ -32,11 +30,6 @@
      0x2f, 0xca, 0x49, 0x01, 0x00, 0x85, 0x11, 0x4a, 0x0d,
      0x0b, 0x00, 0x00, 0x00};
 
-// Re-enable C4309.
-#if defined(OS_WIN)
-#pragma warning( default: 4309 )
-#endif

[Ilya Sherman, 2014/06/09 23:17:00]

What was this about, and why is it appropriate to remove it?

[Alexei Svitkine (slow), 2014/06/10 17:01:15]

It's this warning:

http://msdn.microsoft.com/en-us/library/sz5z1byt.aspx

I think it was some left-over crud that got committed accidentally. My guess is
in a previous version the arrays above were being initialized with decimal
values and were thus triggering the warning. So there was another pragma that
disabled this warning around them and this one was supposed to re-enable it.

If my guess above is correct, then it's not needed anymore. We'll see what the
trybots say.

-
 }  // namespace
 
 TEST(CompressionUtilsTest, GzipCompression) {
@@ -49,4 +42,30 @@
   EXPECT_EQ(golden_compressed_data, compressed_data);
 }
 
+TEST(CompressionUtilsTest, GzipUncompression) {
+  std::string compressed_data(reinterpret_cast<const char*>(kCompressedData),
+                              arraysize(kCompressedData));
+
+  std::string uncompressed_data;
+  EXPECT_TRUE(GzipUncompress(compressed_data, &uncompressed_data));
+
+  std::string golden_data(reinterpret_cast<const char*>(kData),
+                          arraysize(kData));
+  EXPECT_EQ(golden_data, uncompressed_data);
+}
+
+// Checks that compressing/decompressing input > 256 bytes works as expected.
+TEST(CompressionUtilsTest, LargeInput) {
+  const size_t kSize = 32 * 1024;
+
+  std::string data = base::RandBytesAsString(kSize);

[Ilya Sherman, 2014/06/09 23:17:00]

Please log the random input, so that failures are reproducible.

[Alexei Svitkine (slow), 2014/06/10 17:01:15]

Changed this test to use deterministic input instead.

+  std::string compressed_data;
+  EXPECT_TRUE(GzipCompress(data, &compressed_data));
+
+  std::string uncompressed_data;
+  EXPECT_TRUE(GzipUncompress(compressed_data, &uncompressed_data));
+
+  EXPECT_EQ(data, uncompressed_data);
+}
+
 }  // namespace metrics