Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 318183002: Fix repainting of composited RenderViews (Closed)

Created:
6 years, 6 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Fix repainting of composited RenderViews Blink r175423 fixed non-composited nested RenderView repainting for repaint-after-layout, but in the process broke repainting of composited nested RenderViews for all code paths. The fix is to correctly issue repaints to the backing store of composited RenderViews regardless of whether they're nested. BUG=381022 R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175718

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 1

Patch Set 3 : Fix *horrible* naming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
A + LayoutTests/fast/repaint/composited-iframe-scroll-repaint.html View 1 1 chunk +1 line, -3 lines 0 comments Download
A + LayoutTests/fast/repaint/composited-iframe-scroll-repaint-expected.txt View 1 1 chunk +3 lines, -4 lines 0 comments Download
A + LayoutTests/fast/repaint/resources/composited-iframe-scroll-repaint-iframe.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
leviw_travelin_and_unemployed
6 years, 6 months ago (2014-06-06 22:22:03 UTC) #1
esprehn
lgtm https://codereview.chromium.org/318183002/diff/20001/Source/core/rendering/RenderView.cpp File Source/core/rendering/RenderView.cpp (right): https://codereview.chromium.org/318183002/diff/20001/Source/core/rendering/RenderView.cpp#newcode472 Source/core/rendering/RenderView.cpp:472: Element* elt = document().ownerElement(); rename to owner?
6 years, 6 months ago (2014-06-06 22:41:22 UTC) #2
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 6 months ago (2014-06-06 22:49:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/318183002/40001
6 years, 6 months ago (2014-06-06 22:50:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 23:44:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 23:53:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/11224)
6 years, 6 months ago (2014-06-06 23:53:37 UTC) #7
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 6 months ago (2014-06-07 00:26:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/318183002/40001
6 years, 6 months ago (2014-06-07 00:27:02 UTC) #9
leviw_travelin_and_unemployed
6 years, 6 months ago (2014-06-07 00:45:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r175718 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698