Fix the notification center label.

Fix the notification center label.

Fix the notification center label to read
"Chromium Notifications" or "Chrome Notifications"
instead of "Notifications" on Win and Linux and CrOS.
Mac is already working properly.

Passed message_center_unittests and interactive_ui_tests

BUG=350449
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276036

[Pete Williamson, 2014-06-06 20:59:46]

Fix for strings not the same.

[dewittj, 2014-06-06 21:32:37]

Please adjust the issue description to be better for tools:

Summary (<72 char long)

Description (<72 char long)
Description (<72 char long)

R=dewittj@chromium.org
BUG=#

https://codereview.chromium.org/318173002/diff/1/chrome/browser/ui/views/mess...
File chrome/browser/ui/views/message_center/message_center_widget_delegate.cc
(right):

https://codereview.chromium.org/318173002/diff/1/chrome/browser/ui/views/mess...
chrome/browser/ui/views/message_center/message_center_widget_delegate.cc:176:
SetNotificationTitle(notification_title);
Let's put this part up into the constructor of MessageCenterView on line 39 so
we don't have to relayout.  The view should be fully set up before the widget is
told to render it.

https://codereview.chromium.org/318173002/diff/1/ui/message_center/views/mess...
File ui/message_center/views/message_center_button_bar.cc (right):

https://codereview.chromium.org/318173002/diff/1/ui/message_center/views/mess...
ui/message_center/views/message_center_button_bar.cc:124:
l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_FOOTER_TITLE));
This line needs to reflect the new resource so we don't show the wrong label at
first, or require two full layouts before displaying the view.

[Pete Williamson, 2014-06-09 18:30:16]

Also added bug number and made description narrower.

https://codereview.chromium.org/318173002/diff/1/chrome/browser/ui/views/mess...
File chrome/browser/ui/views/message_center/message_center_widget_delegate.cc
(right):

https://codereview.chromium.org/318173002/diff/1/chrome/browser/ui/views/mess...
chrome/browser/ui/views/message_center/message_center_widget_delegate.cc:176:
SetNotificationTitle(notification_title);
On 2014/06/06 21:32:36, dewittj wrote:
> Let's put this part up into the constructor of MessageCenterView on line 39 so
> we don't have to relayout.  The view should be fully set up before the widget
is
> told to render it.

Done.

https://codereview.chromium.org/318173002/diff/1/ui/message_center/views/mess...
File ui/message_center/views/message_center_button_bar.cc (right):

https://codereview.chromium.org/318173002/diff/1/ui/message_center/views/mess...
ui/message_center/views/message_center_button_bar.cc:124:
l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_FOOTER_TITLE));
On 2014/06/06 21:32:36, dewittj wrote:
> This line needs to reflect the new resource so we don't show the wrong label
at
> first, or require two full layouts before displaying the view.

Done.

[dewittj, 2014-06-09 18:34:50]

The "summary" should also be replicated as the first line of the "Description:"
field in Rietveld, followed by a blank line. I don't think commit-bot looks at
"Subject:" at all.

Code lgtm, please fix description field once more

[Pete Williamson, 2014-06-09 18:47:03]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2014-06-09 18:48:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/petewil@chromium.org/318173002/20001

[commit-bot: I haz the power, 2014-06-10 09:00:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-10 15:19:10]

Change committed as 276036