Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 318153004: [NaCl SDK] nacl_io: fix TTY warning messages when using naclterm/hterm. (Closed)

Created:
6 years, 6 months ago by Sam Clegg
Modified:
6 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] nacl_io: fix TTY warning messages when using naclterm/hterm. Passing strings rather than arraybuffers to the tty node is still the only supported way to go, so don't warn about this method being depreceated just yet :) R=binji@chromium.org, binji Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275611

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M native_client_sdk/src/libraries/nacl_io/log.h View 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc View 1 2 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
6 years, 6 months ago (2014-06-06 22:30:09 UTC) #1
binji
lgtm https://codereview.chromium.org/318153004/diff/20001/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc File native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc (right): https://codereview.chromium.org/318153004/diff/20001/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc#newcode535 native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:535: LOG_WARN("Passing TTY data using a string prefix is ...
6 years, 6 months ago (2014-06-06 23:34:20 UTC) #2
Sam Clegg
https://codereview.chromium.org/318153004/diff/20001/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc File native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc (right): https://codereview.chromium.org/318153004/diff/20001/native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc#newcode535 native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:535: LOG_WARN("Passing TTY data using a string prefix is deprected. ...
6 years, 6 months ago (2014-06-07 00:10:43 UTC) #3
Sam Clegg
6 years, 6 months ago (2014-06-07 04:30:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r275611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698