Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 318153002: Remove ftol workaround since we're rolled to Update2 (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Remove ftol workaround since we're rolled to Update2 We were previously linking in this .obj file which patched the broken ftol that was causing floating point stack overflows. This is fixed in VS2013 Update2 and so is no longer required. https://connect.microsoft.com/VisualStudio/feedback/details/808199 R=cpu@chromium.org BUG=348525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
D build/win/ftol3.obj View Binary file 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 6 months ago (2014-06-06 19:16:21 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-06 19:44:41 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-06 19:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/318153002/1
6 years, 6 months ago (2014-06-06 19:53:36 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 01:27:20 UTC) #5
Message was sent while issue was closed.
Change committed as 275581

Powered by Google App Engine
This is Rietveld 408576698