Make CUS interface more resilient by returning a copy of the data

chrome/browser/component_updater/component_updater_service.h

Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index fe77d4e4927b7ca3f0f76a3e1548b57ffe58b460..fe6428d839cc3646be898b102945c9445ea981f1 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -9,6 +9,7 @@
 #include <vector>
 
 #include "base/gtest_prod_util.h"
+#include "base/memory/weak_ptr.h"
 #include "base/version.h"
 #include "url/gurl.h"
 
@@ -207,9 +208,8 @@ class ComponentUpdateService {
   virtual ~ComponentUpdateService() {}
 
  private:
-  // Returns details about registered component. The object returned is owned
-  // by this class. TODO(sorin): replace with a WeakPtr.
-  virtual CrxUpdateItem* GetComponentDetails(
+  // Returns details about registered component.
+  virtual base::WeakPtr<CrxUpdateItem> GetComponentDetails(

[cpu_(ooo_6.6-7.5), 2014/06/09 23:12:57]

This sparked an interesting discussion among few folks. The conclusion is that
WeakPtr is not the appropriate mechanism for this and if you really want to
avoid naked ptrs a const reference would be the best way to go about here.

I personally can live with as is from the perspective of being a private
function or make it a cons ref.

       const std::string& component_id) const = 0;
 
   friend class ::ComponentsUI;