Make CUS interface more resilient by returning a copy of the data

chrome/browser/ui/webui/components_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/components_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
+#include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/component_updater/component_updater_service.h"
 #include "chrome/browser/component_updater/crx_update_item.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
@@ skipping 140 matching lines @@
 // static
 base::ListValue* ComponentsUI::LoadComponents() {
   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
   std::vector<std::string> component_ids;
   component_ids = cus->GetComponentIDs();
 
   // Construct DictionaryValues to return to UI.
   base::ListValue* component_list = new base::ListValue();
   for (size_t j = 0; j < component_ids.size(); ++j) {
-    const component_updater::CrxUpdateItem* item =
+    const base::WeakPtr<component_updater::CrxUpdateItem> item =
         cus->GetComponentDetails(component_ids[j]);
     if (item) {
       base::DictionaryValue* component_entry = new base::DictionaryValue();
       component_entry->SetString("id", component_ids[j]);
       component_entry->SetString("name", item->component.name);
       component_entry->SetString("version",
                                  item->component.version.GetString());
 
       component_entry->SetString("status",
                                  ServiceStatusToString(item->status));
@@ skipping 61 matching lines @@
   return l10n_util::GetStringUTF16(IDS_COMPONENTS_UNKNOWN);
 }
 
 void ComponentsUI::OnEvent(Events event, const std::string& id) {
   base::DictionaryValue parameters;
   parameters.SetString("event", ComponentEventToString(event));
   if (!id.empty())
     parameters.SetString("id", id);
   web_ui()->CallJavascriptFunction("onComponentEvent", parameters);
 }