Make CUS interface more resilient by returning a copy of the data

chrome/browser/component_updater/test/update_checker_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
@@ skipping 37 matching lines @@
                            const std::string& error_message,
                            const UpdateResponse::Results& results);
 
   net::URLRequestContextGetter* context() { return context_.get(); }
 
  protected:
   void Quit();
   void RunThreads();
   void RunThreadsUntilIdle();
 
-  CrxUpdateItem BuildCrxUpdateItem();
+  scoped_ptr<CrxUpdateItem> BuildCrxUpdateItem();
 
   scoped_ptr<UpdateChecker> update_checker_;
 
   scoped_ptr<InterceptorFactory> interceptor_factory_;
   URLRequestPostInterceptor* post_interceptor_;  // Owned by the factory.
 
   int error_;
   std::string error_message_;
   UpdateResponse::Results results_;
 
@@ skipping 66 matching lines @@
 void UpdateCheckerTest::UpdateCheckComplete(
     int error,
     const std::string& error_message,
     const UpdateResponse::Results& results) {
   error_ = error;
   error_message_ = error_message;
   results_ = results;
   Quit();
 }
 
-CrxUpdateItem UpdateCheckerTest::BuildCrxUpdateItem() {
+scoped_ptr<CrxUpdateItem> UpdateCheckerTest::BuildCrxUpdateItem() {
   CrxComponent crx_component;
   crx_component.name = "test_jebg";
   crx_component.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
   crx_component.installer = NULL;
   crx_component.version = base::Version("0.9");
   crx_component.fingerprint = "fp1";
 
-  CrxUpdateItem crx_update_item;
-  crx_update_item.status = CrxUpdateItem::kNew;
-  crx_update_item.id = "jebgalgnebhfojomionfpkfelancnnkf";
-  crx_update_item.component = crx_component;
+  scoped_ptr<CrxUpdateItem> crx_update_item(new CrxUpdateItem());
+  crx_update_item->status = CrxUpdateItem::kNew;
+  crx_update_item->id = "jebgalgnebhfojomionfpkfelancnnkf";
+  crx_update_item->component = crx_component;
 
-  return crx_update_item;
+  return crx_update_item.Pass();
 }
 
 TEST_F(UpdateCheckerTest, UpdateCheckSuccess) {
   EXPECT_TRUE(post_interceptor_->ExpectRequest(
       new PartialMatch("updatecheck"), test_file("updatecheck_reply_1.xml")));
 
   update_checker_ =
       UpdateChecker::Create(GURL("https://localhost2/update2"),
                             context(),
                             base::Bind(&UpdateCheckerTest::UpdateCheckComplete,
                                        base::Unretained(this))).Pass();
 
-  CrxUpdateItem item(BuildCrxUpdateItem());
+  scoped_ptr<CrxUpdateItem> item(BuildCrxUpdateItem());
   std::vector<CrxUpdateItem*> items_to_check;
-  items_to_check.push_back(&item);
+  items_to_check.push_back(item.get());
 
   update_checker_->CheckForUpdates(items_to_check, "extra=\"params\"");
 
   RunThreads();
 
   EXPECT_EQ(1, post_interceptor_->GetHitCount())
       << post_interceptor_->GetRequestsAsString();
   EXPECT_EQ(1, post_interceptor_->GetCount())
       << post_interceptor_->GetRequestsAsString();
 
@@ skipping 27 matching lines @@
   scoped_ptr<PartialMatch> request_matcher(new PartialMatch("updatecheck"));
   EXPECT_FALSE(post_interceptor_->ExpectRequest(request_matcher.get(),
                                                 test_file("no such file")));
 
   update_checker_ =
       UpdateChecker::Create(GURL("https://localhost2/update2"),
                             context(),
                             base::Bind(&UpdateCheckerTest::UpdateCheckComplete,
                                        base::Unretained(this))).Pass();
 
-  CrxUpdateItem item(BuildCrxUpdateItem());
+  scoped_ptr<CrxUpdateItem> item(BuildCrxUpdateItem());
   std::vector<CrxUpdateItem*> items_to_check;
-  items_to_check.push_back(&item);
+  items_to_check.push_back(item.get());
 
   update_checker_->CheckForUpdates(items_to_check, "");
 
   RunThreads();
 
   EXPECT_EQ(0, post_interceptor_->GetHitCount())
       << post_interceptor_->GetRequestsAsString();
   EXPECT_EQ(1, post_interceptor_->GetCount())
       << post_interceptor_->GetRequestsAsString();
 
   EXPECT_NE(0, error_);
   EXPECT_STREQ("network error", error_message_.c_str());
   EXPECT_EQ(0ul, results_.list.size());
 }
 
 }  // namespace component_updater