Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 318143002: Add a new histogram Net.QuicSession.HandshakeConfirmedTime which tracks (Closed)

Created:
6 years, 6 months ago by Ryan Hamilton
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, jar+watch_chromium.org
Visibility:
Public.

Description

Add a new histogram Net.QuicSession.HandshakeConfirmedTime which tracks the elapsed time between starting the crypto handshake, and receiving confirmation from the server. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275654

Patch Set 1 : #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M net/quic/quic_client_session.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Hamilton
Let's see how your filters deal with this CL :>
6 years, 6 months ago (2014-06-06 19:09:18 UTC) #1
jar (doing other things)
lgtm
6 years, 6 months ago (2014-06-06 23:46:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/318143002/60001
6 years, 6 months ago (2014-06-06 23:47:38 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 03:49:15 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:47:11 UTC) #5
Message was sent while issue was closed.
Change committed as 275654

Powered by Google App Engine
This is Rietveld 408576698