Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: media/filters/pipeline_integration_test.cc

Issue 318133002: Always round up coded size to avoid VideoFrame restrictions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Test! Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/filters/pipeline_integration_test_base.h" 5 #include "media/filters/pipeline_integration_test_base.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 1418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1429 1429
1430 // Verify that VP8 video with alpha channel can be played back. 1430 // Verify that VP8 video with alpha channel can be played back.
1431 TEST_F(PipelineIntegrationTest, BasicPlayback_VP8A_WebM) { 1431 TEST_F(PipelineIntegrationTest, BasicPlayback_VP8A_WebM) {
1432 ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8a.webm"), 1432 ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8a.webm"),
1433 PIPELINE_OK)); 1433 PIPELINE_OK));
1434 Play(); 1434 Play();
1435 ASSERT_TRUE(WaitUntilOnEnded()); 1435 ASSERT_TRUE(WaitUntilOnEnded());
1436 EXPECT_EQ(last_video_frame_format_, VideoFrame::YV12A); 1436 EXPECT_EQ(last_video_frame_format_, VideoFrame::YV12A);
1437 } 1437 }
1438 1438
1439 // Verify that VP8A video with odd width/height can be played back. 1439 // Verify that VP8A video with odd width/height can be played back.
scherkus (not reviewing) 2014/06/06 21:25:50 FYI I think the VpxVideoDecoder path got hit by th
DaleCurtis 2014/06/06 21:33:06 Ah, interesting. I think this is okay as a soft f
1440 TEST_F(PipelineIntegrationTest, BasicPlayback_VP8A_Odd_WebM) { 1440 TEST_F(PipelineIntegrationTest, BasicPlayback_VP8A_Odd_WebM) {
1441 ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8a-odd-dimensions.webm"), 1441 ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8a-odd-dimensions.webm"),
1442 PIPELINE_OK)); 1442 PIPELINE_OK));
1443 Play(); 1443 Play();
1444 ASSERT_TRUE(WaitUntilOnEnded()); 1444 ASSERT_TRUE(WaitUntilOnEnded());
1445 EXPECT_EQ(last_video_frame_format_, VideoFrame::YV12A); 1445 EXPECT_EQ(last_video_frame_format_, VideoFrame::YV12A);
1446 } 1446 }
1447 1447
1448 // Verify that VP8 video with inband text track can be played back. 1448 // Verify that VP8 video with inband text track can be played back.
1449 TEST_F(PipelineIntegrationTest, 1449 TEST_F(PipelineIntegrationTest,
1450 BasicPlayback_VP8_WebVTT_WebM) { 1450 BasicPlayback_VP8_WebVTT_WebM) {
1451 ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8-webvtt.webm"), 1451 ASSERT_TRUE(Start(GetTestDataFilePath("bear-vp8-webvtt.webm"),
1452 PIPELINE_OK)); 1452 PIPELINE_OK));
1453 Play(); 1453 Play();
1454 ASSERT_TRUE(WaitUntilOnEnded()); 1454 ASSERT_TRUE(WaitUntilOnEnded());
1455 } 1455 }
1456 1456
1457 // Verify that VP9 video with 4:4:4 subsampling can be played back. 1457 // Verify that VP9 video with 4:4:4 subsampling can be played back.
1458 TEST_F(PipelineIntegrationTest, P444_VP9_WebM) { 1458 TEST_F(PipelineIntegrationTest, P444_VP9_WebM) {
1459 ASSERT_TRUE(Start(GetTestDataFilePath("bear-320x240-P444.webm"), 1459 ASSERT_TRUE(Start(GetTestDataFilePath("bear-320x240-P444.webm"),
1460 PIPELINE_OK)); 1460 PIPELINE_OK));
1461 Play(); 1461 Play();
1462 ASSERT_TRUE(WaitUntilOnEnded()); 1462 ASSERT_TRUE(WaitUntilOnEnded());
1463 EXPECT_EQ(last_video_frame_format_, VideoFrame::YV24); 1463 EXPECT_EQ(last_video_frame_format_, VideoFrame::YV24);
1464 } 1464 }
1465 1465
1466 // Verify that videos with an odd frame size playback successfully.
1467 TEST_F(PipelineIntegrationTest, BasicPlayback_OddVideoSize) {
1468 ASSERT_TRUE(Start(GetTestDataFilePath("butterfly-853x480.webm"),
1469 PIPELINE_OK));
1470 Play();
1471 ASSERT_TRUE(WaitUntilOnEnded());
1472 }
1473
1466 // For MediaSource tests, generate two sets of tests: one using FrameProcessor, 1474 // For MediaSource tests, generate two sets of tests: one using FrameProcessor,
1467 // and one using LegacyFrameProcessor. 1475 // and one using LegacyFrameProcessor.
1468 INSTANTIATE_TEST_CASE_P(NewFrameProcessor, PipelineIntegrationTest, 1476 INSTANTIATE_TEST_CASE_P(NewFrameProcessor, PipelineIntegrationTest,
1469 Values(false)); 1477 Values(false));
1470 INSTANTIATE_TEST_CASE_P(LegacyFrameProcessor, PipelineIntegrationTest, 1478 INSTANTIATE_TEST_CASE_P(LegacyFrameProcessor, PipelineIntegrationTest,
1471 Values(true)); 1479 Values(true));
1472 1480
1473 } // namespace media 1481 } // namespace media
OLDNEW
« media/filters/ffmpeg_video_decoder.cc ('K') | « media/filters/ffmpeg_video_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698