Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 318123003: Add input data parser for Mojo message validation tests. (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Add input data parser for Mojo message validation tests. BUG=None TEST=None R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275831

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -35 lines) Patch
M mojo/mojo_public.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/validation_test_input_parser.h View 1 1 chunk +113 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/validation_test_input_parser.cc View 1 2 1 chunk +363 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 2 5 chunks +158 lines, -27 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/data/validate_header_bad_zeros.data View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/data/validate_header_good_simple.data View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
6 years, 6 months ago (2014-06-06 21:56:04 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/318123003/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc File mojo/public/cpp/bindings/tests/validation_test_input_parser.cc (right): https://codereview.chromium.org/318123003/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc#newcode348 mojo/public/cpp/bindings/tests/validation_test_input_parser.cc:348: return false; nit: indentation https://codereview.chromium.org/318123003/diff/1/mojo/public/cpp/bindings/tests/validation_unittest.cc File mojo/public/cpp/bindings/tests/validation_unittest.cc (right): ...
6 years, 6 months ago (2014-06-08 03:44:33 UTC) #2
yzshen1
Thanks Darin! https://codereview.chromium.org/318123003/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc File mojo/public/cpp/bindings/tests/validation_test_input_parser.cc (right): https://codereview.chromium.org/318123003/diff/1/mojo/public/cpp/bindings/tests/validation_test_input_parser.cc#newcode348 mojo/public/cpp/bindings/tests/validation_test_input_parser.cc:348: return false; On 2014/06/08 03:44:33, darin wrote: ...
6 years, 6 months ago (2014-06-08 06:59:13 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-06-08 08:27:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/318123003/20001
6 years, 6 months ago (2014-06-08 08:28:38 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-08 12:03:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-08 13:45:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/24843)
6 years, 6 months ago (2014-06-08 13:45:08 UTC) #8
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-06-09 06:38:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/318123003/40001
6 years, 6 months ago (2014-06-09 06:39:49 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-09 08:29:00 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 08:53:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/149934)
6 years, 6 months ago (2014-06-09 08:53:48 UTC) #13
yzshen1
6 years, 6 months ago (2014-06-09 17:30:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 manually as r275831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698