Telemetry: Last ditch effort to dump symbols on tab crashes if none are found

Telemetry: Last ditch effort to dump symbols on tab crashes if none are found

Put this together to find a crash which only happened on telemetry unittest runs on Mac trybots; figured it might be useful for later too.

R=dtu,tonyg
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275675

[tonyg, 2014-06-06 19:47:44]

lgtm++

Thanks so much for doing this :)

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py:289:
logging.warning('No breakpad symbols found; trying to dump them.')
This case isn't that exceptional. Let's just do:

logging.info('Dumping breakpad symbols')

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py:291:
self._browser_directory, "..", "..", "components", "breakpad",
Are the two parent dirs always right? Should we be formal and use os.pardir?

Alternatively, would this always work?

os.path.join(util.GetChromiumSrcDir(),
             'components', 'breakpad', 'tools',
             'generate_breakpad_symbols.py')

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py:294:
generate_breakpad_symbols_path,
I think we need to add sys.executable as the first element in this array for
windows.

[oystein (OOO til 10th of July), 2014-06-06 22:17:58]

Thanks :)

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py:289:
logging.warning('No breakpad symbols found; trying to dump them.')
On 2014/06/06 19:47:44, tonyg wrote:
> This case isn't that exceptional. Let's just do:
> 
> logging.info('Dumping breakpad symbols')

Done.

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py:291:
self._browser_directory, "..", "..", "components", "breakpad",
On 2014/06/06 19:47:44, tonyg wrote:
> Are the two parent dirs always right? Should we be formal and use os.pardir?
> 
> Alternatively, would this always work?
> 
> os.path.join(util.GetChromiumSrcDir(),
>              'components', 'breakpad', 'tools',
>              'generate_breakpad_symbols.py')

Done.

https://codereview.chromium.org/318123002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py:294:
generate_breakpad_symbols_path,
On 2014/06/06 19:47:44, tonyg wrote:
> I think we need to add sys.executable as the first element in this array for
> windows.

Done.

[oystein (OOO til 10th of July), 2014-06-06 22:18:01]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2014-06-06 22:20:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oysteine@chromium.org/318123002/40001

[dtu, 2014-06-06 23:49:49]

lgtm

[commit-bot: I haz the power, 2014-06-07 10:06:49]

Change committed as 275675

[Joao da Silva, 2014-06-07 14:07:36]

A revert of this CL has been created in
https://codereview.chromium.org/320693002/ by joaodasilva@chromium.org.

The reason for reverting is:
page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab is failing on the
main waterfall after this change:

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/b...

http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/b...

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11451.