Issue 3181030: bookmarks: Add HasBookmarks() method to BookmarkModel API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3181030: bookmarks: Add HasBookmarks() method to BookmarkModel API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by tfarina

Modified:
4 years ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

bookmarks: Add HasBookmarks() method to BookmarkModel API. BUG=45551 TEST=out/Debug/unit_tests --gtest_filter=BookmarkModelTest.HasBookmarks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57611

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -0 lines)			Patch
M	chrome/browser/bookmarks/bookmark_model.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Trybot results: linux win mac

Total messages: 3 (0 generated)

Miranda Callahan

4 years, 9 months ago (2010-08-25 20:44:30 UTC) #3

LGTM after it passes the windows trybot.  Thanks!