Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 3181029: Mac: Show a context menu for poup window. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm
index d7c182812d95a473ed877e19fedd5d77361b396b..e5dce143150b4feef9a0350dcb2625685dc8ee48 100644
--- a/chrome/browser/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/cocoa/browser_window_cocoa.mm
@@ -569,6 +569,27 @@ void BrowserWindowCocoa::Observe(NotificationType type,
}
}
+bool BrowserWindowCocoa::IsCommandIdChecked(int command_id) const {
+ // Currently no items in our popup context menu are check-able.
+ return false;
+}
+
+bool BrowserWindowCocoa::IsCommandIdEnabled(int command_id) const {
+ return browser_->command_updater()->IsCommandEnabled(command_id);
+}
+
+bool BrowserWindowCocoa::GetAcceleratorForCommandId(
+ int command_id,
+ menus::Accelerator* accelerator) {
+ // This is not necessary because Cocoa does not show short-cut keys
+ // for context menu items.
+ return false;
+}
+
+void BrowserWindowCocoa::ExecuteCommand(int command_id) {
+ browser_->ExecuteCommand(command_id);
+}
+
void BrowserWindowCocoa::DestroyBrowser() {
[controller_ destroyBrowser];

Powered by Google App Engine
This is Rietveld 408576698