Mac: Show a context menu for poup window.

chrome/browser/cocoa/tab_window_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/tab_window_controller.h"
 
 #include "app/theme_provider.h"
 #include "base/logging.h"
 #import "chrome/browser/cocoa/tab_strip_view.h"
 #import "chrome/browser/cocoa/themed_window.h"
 
 @interface TabWindowController(PRIVATE)
 - (void)setUseOverlay:(BOOL)useOverlay;
 @end
 
+@interface PopupStripView : NSView {
+ @protected

[viettrungluu, 2010/08/20 17:02:00]

why protected and not private?

+  TabWindowController* controller_; // weak: own us.

[viettrungluu, 2010/08/20 17:02:00]

s/own/owns/

+}
+
+- (void)setController:(TabWindowController*)controller;

[viettrungluu, 2010/08/20 17:02:00]

Just declare it as a @property; in general, things with setters should have
getters.

+@end
+
+@implementation PopupStripView
+- (id)initWithFrame:(NSRect)frameRect {
+  if ((self = [super initWithFrame:frameRect]) != nil) {
+    controller_ = nil;
+  }
+  return self;
+}
+
+- (BOOL)acceptsFirstMouse:(NSEvent*)event {
+  return YES;
+}
+
+- (NSMenu *)menuForEvent:(NSEvent*)event {
+  if (!controller_)
+    return nil;
+  return [controller_ popupContextMenu];
+}
+
+- (void)setController:(TabWindowController*)controller {
+  controller_ = controller;
+}
+@end
+
 @interface TabWindowOverlayWindow : NSWindow
 @end
 
 @implementation TabWindowOverlayWindow
 
 - (ThemeProvider*)themeProvider {
   if ([self parentWindow])
     return [[[self parentWindow] windowController] themeProvider];
   return NULL;
 }
@@ skipping 42 matching lines @@
   NSRect contentFrame = [tabContentArea_ frame];
   NSRect tabFrame =
       NSMakeRect(0, NSMaxY(contentFrame),
                  NSWidth(contentFrame),
                  NSHeight([topTabStripView_ frame]));
   [topTabStripView_ setFrame:tabFrame];
   NSView* contentParent = [[[self window] contentView] superview];
   [contentParent addSubview:topTabStripView_];
 }
 
+- (void)addPopupStripToWindow {
+  NSRect contentFrame = [[[self window] contentView] frame];

[viettrungluu, 2010/08/20 17:02:00]

Please do |NSView* contentView = [[self window] contentView];| and use that.

+  NSRect outerFrame = [[[[self window] contentView] superview] frame];
+  NSRect stripFrame = 
+      NSMakeRect(0, 
+                 NSMaxY(contentFrame),
+                 NSWidth(contentFrame),
+                 NSHeight(outerFrame) - NSHeight(contentFrame));
+  [popupStripView_ setFrame:stripFrame];
+  [popupStripView_ setController:self];
+
+  NSView* contentParent = [[[self window] contentView] superview];

[viettrungluu, 2010/08/20 17:02:00]

You can probably now do |[[contentView superview] addSubview:popupStripView_];|
below. Or, if you want to do this, you may as well do it at the top.

+  [contentParent addSubview:popupStripView_];
+}
+
 - (void)windowDidLoad {
   // Cache the difference in height between the window content area and the
   // tab content area.
   NSRect tabFrame = [tabContentArea_ frame];
   NSRect contentFrame = [[[self window] contentView] frame];
   contentAreaHeightDelta_ = NSHeight(contentFrame) - NSHeight(tabFrame);
 
   if ([self hasTabStrip]) {
     if ([self useVerticalTabs]) {
       // No top tabstrip so remove the tabContentArea offset.
       tabFrame.size.height = contentFrame.size.height;
       [tabContentArea_ setFrame:tabFrame];
       [self addSideTabStripToWindow];
     } else {
       [self addTopTabStripToWindow];
     }
   } else {
     // No top tabstrip so remove the tabContentArea offset.
     tabFrame.size.height = contentFrame.size.height;
     [tabContentArea_ setFrame:tabFrame];
+    [self addPopupStripToWindow];
   }
 }
 
 // Toggles from one display mode of the tab strip to another. Will automatically
 // call -layoutSubviews to reposition other content.
 - (void)toggleTabStripDisplayMode {
   // Adjust the size of the tab contents to either use more or less space,
   // depending on the direction of the toggle. This needs to be done prior to
   // adding back in the top tab strip as its position is based off the MaxY
   // of the tab content area.
@@ skipping 224 matching lines @@
 - (void)deferPerformClose {
   closeDeferred_ = YES;
 }
 
 // Called when the size of the window content area has changed. Override to
 // position specific views. Base class implementation does nothing.
 - (void)layoutSubviews {
   NOTIMPLEMENTED();
 }
 
+- (NSMenu*)popupContextMenu {
+  return nil; // Doesn't show a context menu at the default.

[viettrungluu, 2010/08/20 17:02:00]

s/at the/by/

+}
 @end