Mac: Show a context menu for poup window.

chrome/browser/cocoa/browser_window_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/browser_window_controller.h"
 
 #include <Carbon/Carbon.h>
 
 #include "app/l10n_util.h"
 #include "app/l10n_util_mac.h"
+#include "app/menus/simple_menu_model.h"
 #include "base/mac_util.h"
 #include "base/nsimage_cache_mac.h"
 #include "base/scoped_nsdisable_screen_updates.h"
 #import "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_dll_resource.h"  // IDC_*
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_theme_provider.h"
 #include "chrome/browser/dock_info.h"
@@ skipping 10 matching lines @@
 #import "chrome/browser/cocoa/download_shelf_controller.h"
 #import "chrome/browser/cocoa/event_utils.h"
 #import "chrome/browser/cocoa/fast_resize_view.h"
 #import "chrome/browser/cocoa/find_bar_cocoa_controller.h"
 #import "chrome/browser/cocoa/find_bar_bridge.h"
 #import "chrome/browser/cocoa/focus_tracker.h"
 #import "chrome/browser/cocoa/fullscreen_controller.h"
 #import "chrome/browser/cocoa/fullscreen_window.h"
 #import "chrome/browser/cocoa/infobar_container_controller.h"
 #import "chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.h"
+#import "chrome/browser/cocoa/menu_controller.h"
 #import "chrome/browser/cocoa/sad_tab_controller.h"
 #import "chrome/browser/cocoa/status_bubble_mac.h"
 #import "chrome/browser/cocoa/tab_contents_controller.h"
 #import "chrome/browser/cocoa/tab_strip_model_observer_bridge.h"
 #import "chrome/browser/cocoa/tab_strip_controller.h"
 #import "chrome/browser/cocoa/tab_strip_view.h"
 #import "chrome/browser/cocoa/tab_view.h"
 #import "chrome/browser/cocoa/tabpose_window.h"
 #import "chrome/browser/cocoa/toolbar_controller.h"
 #include "chrome/browser/renderer_host/render_widget_host_view.h"
@@ skipping 84 matching lines @@
 @interface NSWindow(NSPrivateApis)
 // Note: These functions are private, use -[NSObject respondsToSelector:]
 // before calling them.
 
 - (void)setBottomCornerRounded:(BOOL)rounded;
 
 - (NSRect)_growBoxRect;
 
 @end
 
+// BrowserWindowPopupMenuController subclasses MenuController to

[viettrungluu, 2010/08/20 17:02:00]

Why is this in browser_window_controller.mm?

+// provide menu items for the popup context menu.
+@interface BrowserWindowPopupMenuController : MenuController {
+  scoped_ptr<menus::SimpleMenuModel> popupModel_;

[viettrungluu, 2010/08/20 17:02:00]

@private

+}
+
+- (id)initWithDelegate:(menus::SimpleMenuModel::Delegate*)delegate;
+@end
+
+@implementation BrowserWindowPopupMenuController
+- (menus::SimpleMenuModel*)newModelFor:(menus::SimpleMenuModel::Delegate*)delegate {

[viettrungluu, 2010/08/20 17:02:00]

80 chars

+  menus::SimpleMenuModel* result = new menus::SimpleMenuModel(delegate);
+  result->AddItemWithStringId(IDC_COPY_URL,
+                              IDS_APP_MENU_COPY_URL);
+  result->AddItemWithStringId(IDC_SHOW_AS_TAB,
+                              IDS_SHOW_AS_TAB);
+  result->AddSeparator();
+  result->AddItemWithStringId(IDC_RELOAD, IDS_APP_MENU_RELOAD);
+  result->AddItemWithStringId(IDC_FORWARD,
+                              IDS_CONTENT_CONTEXT_FORWARD);
+  result->AddItemWithStringId(IDC_BACK,
+                              IDS_CONTENT_CONTEXT_BACK);
+  return result;
+}
+
+- (id)initWithDelegate:(menus::SimpleMenuModel::Delegate*)delegate {
+  if ((self = [super init]) != nil) {

[viettrungluu, 2010/08/20 17:02:00]

'!= nil' not needed

+    popupModel_.reset([self newModelFor:delegate]);
+    [self setModel: popupModel_.get()];

[viettrungluu, 2010/08/20 17:02:00]

no space after ':'

+  }
+
+  return self;
+}
+@end
 
 // IncognitoImageView subclasses NSImageView to allow mouse events to pass
 // through it so you can drag the window by dragging on the spy guy
 @interface IncognitoImageView : NSImageView
 @end
 
 @implementation IncognitoImageView
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
@@ skipping 1478 matching lines @@
 - (BOOL)useVerticalTabs {
   return browser_->tabstrip_model()->delegate()->UseVerticalTabs();
 }
 
 - (void)sheetDidEnd:(NSWindow*)sheet
          returnCode:(NSInteger)code
             context:(void*)context {
   [sheet orderOut:self];
 }
 
+- (NSMenu*)popupContextMenu {

[viettrungluu, 2010/08/20 17:02:00]

Should you check that this is a popup window?

+  if (!popupMenuController_) {
+    popupMenuController_.reset(
+        [[BrowserWindowPopupMenuController alloc] initWithDelegate:windowShim_.get()]);

[viettrungluu, 2010/08/20 17:02:00]

80 chars

+  }
+
+  return [popupMenuController_ menu];
+}
 @end  // @implementation BrowserWindowController
 
 
 @implementation BrowserWindowController(Fullscreen)
 
 - (void)setFullscreen:(BOOL)fullscreen {
   // The logic in this function is a bit complicated and very carefully
   // arranged.  See the below comments for more details.
 
   if (fullscreen == [self isFullscreen])
@@ skipping 233 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isNormalWindow {
   return browser_->type() == Browser::TYPE_NORMAL;
 }
 
 @end  // @implementation BrowserWindowController(WindowType)