Clean up some naming.

src/string.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 313 matching lines @@
     parameters[j] = CaptureString(subject, captures, j);
   }
   parameters[j] = index;
   parameters[j + 1] = subject;
   return ToString(replace.apply(null, parameters));
 }
 
 
 // ECMA-262 section 15.5.4.7
 %AddProperty($String.prototype, "indexOf", function(searchString /* position */) {  // length == 1
-  var str = ToString(this);
-  var str_len = str.length;
-  var searchStr = ToString(searchString);
+  var subject_str = ToString(this);
+  var pattern_str = ToString(searchString);
+  var subject_str_len = subject_str.length;
+  var pattern_str_len = pattern_str.length;
   var index = 0;
   if (%_ArgumentsLength() > 1) {
     var arg1 = %_Arguments(1);  // position
     index = TO_INTEGER(arg1);
   }
   if (index < 0) index = 0;
-  if (index > str_len) index = str_len;
-  if (searchStr.length + index > str_len) return -1;
-  return %StringIndexOf(str, searchStr, index);
+  if (index > subject_str_len) index = subject_str_len;
+  if (pattern_str_len + index > subject_str_len) return -1;
+  return %StringIndexOf(subject_str, pattern_str, index);
 }, DONT_ENUM);
 
 
 // ECMA-262 section 15.5.4.8
 %AddProperty($String.prototype, "lastIndexOf", function(searchString /* position */) {  // length == 1
   var sub = ToString(this);
   var pat = ToString(searchString);
   var index = (%_ArgumentsLength() > 1)
       ? ToNumber(%_Arguments(1) /* position */)
       : $NaN;
@@ skipping 407 matching lines @@
 
 
 StringBuilder.prototype.generate = function() {
   return %StringBuilderConcat(this.elements, "");
 }
 
 
 ReplaceResultBuilder.prototype.generate = function() {
   return %StringBuilderConcat(this.elements, this.special_string);
 }